fix: cleanup plugin install state on failed installations (#1113)

Author: bajrangCoder

src/lib/installPlugin.js

@@ -17,6 +17,7 @@ export default async function installPlugin(id, name, purchaseToken) {
 	const loaderDialog = loader.create(title, strings.installing);
 	let pluginDir;
 	let pluginUrl;
+	let state;
 
 	try {
 		if (!(await fsOperation(PLUGIN_DIR).exists())) {
@@ -71,7 +72,7 @@ export default async function installPlugin(id, name, purchaseToken) {
 				pluginDir = Url.join(PLUGIN_DIR, id);
 			}
 
-			const state = await InstallState.new(id);
+			state = await InstallState.new(id);
 
 			if (!(await fsOperation(pluginDir).exists())) {
 				await fsOperation(PLUGIN_DIR).createDirectory(id);
@@ -115,9 +116,15 @@ export default async function installPlugin(id, name, purchaseToken) {
 		}
 	} catch (err) {
 		try {
-			await fsOperation(pluginDir).delete();
-		} catch (error) {
-			// ignore
+			// Clear the install state if installation fails
+			if (state) await state.clear();
+
+			// Delete the plugin directory if it was created
+			if (pluginDir && (await fsOperation(pluginDir).exists())) {
+				await fsOperation(pluginDir).delete();
+			}
+		} catch (cleanupError) {
+			console.error("Cleanup failed:", cleanupError);
 		}
 		throw err;
 	} finally {

src/lib/installState.js

@@ -82,6 +82,16 @@ export default class InstallState {
 			await fsOperation(url).delete();
 		}
 	}
+
+	async clear() {
+		try {
+			this.store = {};
+			this.updatedStore = {};
+			await fsOperation(this.storeUrl).writeFile("{}");
+		} catch (error) {
+			console.error("Failed to clear install state:", error);
+		}
+	}
 }
 
 /**