From 91a2bfefedd30690756cb1d2131f844a57e7c69a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Mon, 20 Jan 2025 20:38:59 +0100 Subject: [PATCH] Remove duplicate cmake dependency from skbuild plugin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the duplicate `cmake` dependency that was added by `openexr_skbuild_plugin.py`. Scikit-build-core is adding a dependency on CMake if necessary itself, and adding one unconditionally has a side effect of installing a local PyPI version of CMake that overrides the system CMake that scikit-build-core would be using instead. This can be particularly problematic when downstream patching of CMake is required on the system in question. Fixes #1957 Signed-off-by: Michał Górny --- src/wrappers/python/openexr_skbuild_plugin.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/wrappers/python/openexr_skbuild_plugin.py b/src/wrappers/python/openexr_skbuild_plugin.py index ea09221b46..0e9828d8c2 100644 --- a/src/wrappers/python/openexr_skbuild_plugin.py +++ b/src/wrappers/python/openexr_skbuild_plugin.py @@ -99,8 +99,3 @@ def dynamic_metadata( print("openexr_skbuild_plugin: Computed version: {0}".format(version)) return version - -def get_requires_for_dynamic_metadata( - _settings: Optional[Dict[str, object]] = None, -) -> List[str]: - return ["cmake"]