Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocioconvert silently errors out when given invalid bitdepth running on Windows #2110

Open
KevinJW opened this issue Dec 24, 2024 · 1 comment
Labels
good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development.

Comments

@KevinJW
Copy link
Contributor

KevinJW commented Dec 24, 2024

When calling ocioconvert from a terminal on windows and an invalid bitdepth is given, it does not output the intended error message:

https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/src/apps/ocioconvert/main.cpp#L142

This is because the throw is not within a try/catch block and exceptions produce no output unless you do something with them.

Suggest turning this into a simple std:cerr message and exit() with an appropriate error code.

@KevinJW KevinJW added the good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development. label Dec 24, 2024
@Ayush-Mittal10
Copy link

I want to work on it. How can I start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development.
Projects
None yet
Development

No branches or pull requests

2 participants