#303: Get flow checkpoints refactoring #304
Open
+818
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release notes:
|
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
benedeki
changed the title
benedeki
reviewed
Nov 22, 2024
database/src/main/postgres/flows/V0.3.0.1__get_flow_checkpoints.sql
Outdated
Show resolved
Hide resolved
database/src/main/postgres/flows/V0.3.0.1__get_flow_checkpoints.sql
Outdated
Show resolved
Hide resolved
database/src/main/postgres/flows/V0.3.0.1__get_flow_checkpoints.sql
Outdated
Show resolved
Hide resolved
model/src/main/scala/za/co/absa/atum/model/dto/CheckpointWithPartitioningDTO.scala
Show resolved
Hide resolved
server/src/main/scala/za/co/absa/atum/server/model/CheckpointItemWithPartitioningFromDB.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/za/co/absa/atum/server/model/CheckpointItemWithPartitioningFromDB.scala
Outdated
Show resolved
Hide resolved
|
|
||
| object CheckpointItemWithPartitioningFromDB { | ||
|
|
||
| private def fromItemsToCheckpointWithPartitioningDTO( |
There was a problem hiding this comment.
Name suggestion:
Wouldn't be def groupCheckpoint be easier to understand?
There was a problem hiding this comment.
I don't know. Naming is difficult...
server/src/main/scala/za/co/absa/atum/server/model/CheckpointItemWithPartitioningFromDB.scala
Outdated
Show resolved
Hide resolved
server/src/main/scala/za/co/absa/atum/server/model/CheckpointItemWithPartitioningFromDB.scala
Show resolved
Hide resolved
Co-authored-by: David Benedeki <[email protected]>
…-refactoring' into feature/303-get-flow-checkpoints-refactoring
…temWithPartitioningFromDB.scala Co-authored-by: David Benedeki <[email protected]>
benedeki
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of get flow checkpoints endpoint. It newly returns also partitioning data and is sorted in descending order by checkpoint start time.
Closes #303
Release notes: