#245 Add the ability to query REST endpoints from Reader module #297
+1,248
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created new module Info * the new modul added to JaCoco and CI routines
* JaCoCo exclusion for model
* created Provider to query the data from server * support for Future, IO, and ZIO based providers * work in progress
benedeki
added
the
work in progress
* fixed license headers
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
benedeki
commented
Nov 6, 2024
|
|
||
| protected def executeRequest[R](request: RequestT[Identity, RequestResult[R], Any]): F[Response[RequestResult[R]]] | ||
|
|
||
| def getQuery[R: Decoder](endpointUri: String, params: Map[String, String] = Map.empty): F[RequestResult[R]] = { |
There was a problem hiding this comment.
Not sure about the return type of this key function. Particularly the error case. But it can be relatively easily adjusted in future.
benedeki
requested review from
Zejnilovic,
dk1844 and
salamonpavel
as code owners
salamonpavel
reviewed
Nov 6, 2024
| val expected: Unit = () | ||
| for { | ||
| result <- connection.close() | ||
| } yield assertTrue(result == expected) |
There was a problem hiding this comment.
There are plenly of built-in assertions in ZIO.
https://zio.dev/reference/test/assertions/
assertZIO(connection.close())(isUnit)
salamonpavel
reviewed
Nov 6, 2024
| @@ -18,6 +18,8 @@ package za.co.absa.atum.reader | |||
|
|
|||
| import org.scalatest.funsuite.AnyFunSuiteLike | |||
|
|
|||
| import za.co.absa.atum.reader.server.future.ArmeriaServerConnection.serverConnection | |||
|
|
|||
| class FlowReaderUnitTests extends AnyFunSuiteLike { | |||
| test("foo") { | |||
| val expected = new FlowReader().foo() | |||
There was a problem hiding this comment.
this is actual value, the expected one is "bar" (it's the other way around)
salamonpavel
reviewed
Nov 6, 2024
| @@ -18,6 +18,8 @@ package za.co.absa.atum.reader | |||
|
|
|||
| import org.scalatest.funsuite.AnyFunSuiteLike | |||
|
|
|||
| import za.co.absa.atum.reader.server.future.ArmeriaServerConnection.serverConnection | |||
|
|
|||
| class PartitioningReaderUnitTests extends AnyFunSuiteLike { | |||
| test("foo") { | |||
| val expected = new PartitioningReader().foo() | |||
There was a problem hiding this comment.
this is actual value, the expected one is "bar" (it's the other way around)
salamonpavel
reviewed
Nov 6, 2024
benedeki
added
the
dependent
benedeki
removed
the
dependent
|
This item depends on: |
…endpoints-from-info-module
benedeki
removed
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenericServerConnectionoffering the ability to query the Atum serverREADME.mdupdated to instruct how to use the Reader module and it's optional dependenciesGenericServerConnection.getQueryGenericServerConnection.getQuery, particularly the error caseCloses #245
Depends on #300
Release Notes: