Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scala plugin optional dependency #485

Open
OlliKiljunen opened this issue Jan 20, 2021 · 1 comment
Open

Make Scala plugin optional dependency #485

OlliKiljunen opened this issue Jan 20, 2021 · 1 comment
Labels
investigate low low priority issue

Comments

@OlliKiljunen
Copy link
Member

We are planning to move REPL into a separate plugin (see #484). After that, the only thing that keep our plugin dependent on Scala plugin is ScalaSDK class.

ScalaSDK class gets loaded only if user installs a module which has a scala-sdk as an external library. Ideally, unless that happens, our plug-in should be usable without Scala plugin.

To achieve this

  • make scala plugin an optional dependency
  • in CommonLibraryProvider::createLibrary check that Scala plugin is loaded before instantiating ScalaSDK class.

It is not sure if this is possible, so investigate.

Blocked by #484.

@OlliKiljunen OlliKiljunen added low low priority issue investigate labels Jan 20, 2021
@stellatsv stellatsv added this to the Support for Python courses milestone May 14, 2021
@OlliKiljunen
Copy link
Member Author

Decision: Let's keep this ticket open for now to remind us of the possibility to some day make the plugin support other languages as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate low low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants