Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type constants should be removed #867

Open
algomaster99 opened this issue Aug 21, 2022 · 0 comments
Open

Type constants should be removed #867

algomaster99 opened this issue Aug 21, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@algomaster99
Copy link
Member

Constants for types like float are defined here. We can instead use Spoon's factory methods to compare types of two objects. For example:

- ctBinaryOperator.getLeftHandOperand().getType().getSimpleName().equals(Constants.FLOAT)
+ ctBinaryOperator.getLeftHandOperand().getType().equals(factory.Type().floatPrimitiveType())
@algomaster99 algomaster99 added the good first issue Good for newcomers label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
1 participant
@algomaster99