Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set MAVEN mode as the default mode #681

Open
monperrus opened this issue Dec 15, 2021 · 3 comments
Open

set MAVEN mode as the default mode #681

monperrus opened this issue Dec 15, 2021 · 3 comments

Comments

@monperrus
Copy link
Contributor

follow up of #347

MAVEN mode should give better bindings, better imports and overall better results.

@algomaster99
Copy link
Member

@monperrus Using the maven mode requires passing --resolve-classpath-from and the client has to give it the path to a valid maven project. I think we should not make it the default mode because if someone does not want to use the above flag, they will have to explicitly specify that they want the current default mode.

Maybe we can highlight in the README that we recommend using maven mode. What do you think?

@monperrus
Copy link
Contributor Author

Good point. In Maven mode, regardless it's default or not, we can automatically infer the arguments to be given to --resolve-classpath-from

@algomaster99
Copy link
Member

More context: #598 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants