Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize warnings miner by running all checks in one pass #168

Closed
slarse opened this issue Oct 27, 2020 · 0 comments · Fixed by #175
Closed

Optimize warnings miner by running all checks in one pass #168

slarse opened this issue Oct 27, 2020 · 0 comments · Fixed by #175
Labels
enhancement New feature or request

Comments

@slarse
Copy link
Collaborator

slarse commented Oct 27, 2020

Currently, the warnings miner loops through the checks and applies them one-by-one, which essentially means re-parsing the file and traversing the AST for each check. Running time can be drastically reduced by applying all checks in one pass, which will be easy to do once #156 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Run all checks in one pass in warnings miner slarse/sorald
1 participant
@slarse