-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeEditor: Hinting and Completion #97
Comments
@braxtonmckee I am making decent progress with this today (although Ace docs on adding custom completions is somewhat sparse). The current set up allows you to define a custom completion func on the server side in cells.CodeEditor and when you do so the component knows to use it instead of the default Ace ones. Now do you want this custom completion to replace or complement the Ace ones or do you want a CodeEditor side option for either one? In the latter case, I could see if there is a way to make sure the the custom results come up first or always come up. |
Cool!
I think if the client side specifies a completion function, we should use
that in lieu of the builtin one entirely. Also, it would be bad if the ace
editor blocks on a round-trip with the server to show the autocomplete, so
hopefully it can be async.
…On Wed, Mar 25, 2020 at 10:43 AM dkrasner ***@***.***> wrote:
@braxtonmckee <https://github.com/braxtonmckee> I am making decent
progress with this today (although Ace docs on adding custom completions is
somewhat sparse). The current set up allows you to define a custom
completion func on the server side in cells.CodeEditor and when you do so
the component knows to use it instead of the default Ace ones. Now do you
want this custom completion to replace or complement the Ace ones or do you
want a CodeEditor side option for either one? In the latter case, I could
see if there is a way to make sure the the custom results come up first or
always come up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6OHBEQRO3MNOSDEQW6ZGTRJIKAHANCNFSM4K4PASZA>
.
|
ok got it - this is what i have going implement right now note, the way that ace bundles these completion functions it waits until all of them return, which in our case would include on waiting on the server. At this least this is what I see from their code and my initial tests |
@braxtonmckee ok we have something working #106 - can be enhanced as needed |
Ace editor has a nice framework for making suggestions when we type. We need an API on the python side that could hook into that so that as we're typing the system can provide suggestions. Ideally we'd be able to specify callbacks to the constructor on the python side where it would call them with the current cursor position and current text buffer and get back a list of suggestions and send that up to the client side.
The text was updated successfully, but these errors were encountered: