Replaces the deprecated Templating dependency with Twig (#46)

* Use Twig instead of templating / EngineInterface * Use Twig instead of templating / EngineInterface * Update .gitignore Co-authored-by: Richard van Laak <[email protected]>
APY · Nov 4, 2019 · e331dcc · e331dcc
1 parent 199eae1
commit e331dcc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+/vendor/
diff --git a/Resources/config/services.xml b/Resources/config/services.xml
@@ -22,7 +22,7 @@
 
         <service id="apy_breadcrumb_trail.twig.extension" class="%apy_breadcrumb_trail.twig.extension.class%">
             <argument type="service" id="apy_breadcrumb_trail" />
-            <argument type="service" id="templating" />
+            <argument type="service" id="twig" />
             <tag name="twig.extension" />
         </service>
 

diff --git a/Twig/BreadcrumbTrailExtension.php b/Twig/BreadcrumbTrailExtension.php
@@ -12,12 +12,13 @@
 namespace APY\BreadcrumbTrailBundle\Twig;
 
 use APY\BreadcrumbTrailBundle\BreadcrumbTrail\Trail;
-use Symfony\Component\Templating\EngineInterface;
+use Twig\Environment;
+use Twig\Extension\AbstractExtension;
 
 /**
  * Provides an extension for Twig to output breadcrumbs
  */
-class BreadcrumbTrailExtension extends \Twig_Extension
+class BreadcrumbTrailExtension extends AbstractExtension
 {
     private $trail;
     private $templating;
@@ -26,9 +27,9 @@ class BreadcrumbTrailExtension extends \Twig_Extension
     /**
      * BreadcrumbTrailExtension constructor.
      * @param Trail $trail
-     * @param EngineInterface $templating
+     * @param Environment $templating
      */
-    public function __construct(Trail $trail, EngineInterface $templating)
+    public function __construct(Trail $trail, Environment $templating)
     {
         $this->trail = $trail;
         $this->templating = $templating;

diff --git a/composer.json b/composer.json
@@ -13,7 +13,8 @@
     ],
     "require": {
         "php": ">=5.3.3",
-        "symfony/framework-bundle": "^2.3|^3.0|^4.0"
+        "symfony/framework-bundle": "^2.3|^3.0|^4.0",
+        "twig/twig": "^1.41|^2.0"
     },
     "suggest": {
         "ext-intl": "*"