You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't perform validation if I ask for it. The documentation says all methods take the same options, which leads me to believe that I could request validation when bundling:
throwono.syntax(`${args.path||args.schema} is not a valid Openapi API definition`);
}
It's worth noting that json-schema-ref-parser, which outwardly appears to have the same bundle(), and is used by this package, doesn't do the unwanted validation (I initially used that and switched to this package when I found that opting in to validation doesn't work):
$RefParser.bundle({})
Actual result:
Fulfills with output, no error.
The text was updated successfully, but these errors were encountered:
Hello,
Thanks for your work on this.
Validation behavior and documentation has room for improvement.
This is with version 10.0.2.
https://runkit.com/60d21a4e32916a0013c0a954/6112cce77f5afb001eec2d34
It doesn't perform validation if I ask for it. The documentation says all methods take the same options, which leads me to believe that I could request validation when bundling:
Expected result:
Rejects with validation error(s).
Actual result:
Fulfills, no error.
Worse, it performs half-baked validation that I don't ask for:
Even if I explicitly try to opt out!
(Again, these
validate
options that are documented like they're applicable tobundle()
don't do anything inbundle()
.)Expected result:
No error, fulfills with bundled output.
Actual result:
Rejects with cryptic error:
swagger-parser/lib/index.js
Lines 82 to 85 in c47b3f5
It's worth noting that json-schema-ref-parser, which outwardly appears to have the same
bundle()
, and is used by this package, doesn't do the unwanted validation (I initially used that and switched to this package when I found that opting in to validation doesn't work):Actual result:
Fulfills with output, no error.
The text was updated successfully, but these errors were encountered: