You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LGS elongation does not work when using ShackHartmann and one have to use ShackHartmannLegacy to be able to used it. This is because lineofsight.py and lineofsight_legacy.py diverge significantly.
Not sure what is the idea, what was the motivation to have legacy files, and how much the legacy versions might be outdated.
Modifying base.py and lineofsight.py to make the LGS elongation works do not seem trivial to me.
What is your advice or plan here?
Thanks
The text was updated successfully, but these errors were encountered:
From discussion wiht @ojdf - In the new concept, a new "LineOfSIght" object would be required for each "elongation point" along the LGS beacon. Hopefully this works with the current SH and LOS, and is a bit more elegant internally.
Hi,
LGS elongation does not work when using
ShackHartmann
and one have to useShackHartmannLegacy
to be able to used it. This is becauselineofsight.py
andlineofsight_legacy.py
diverge significantly.Not sure what is the idea, what was the motivation to have legacy files, and how much the legacy versions might be outdated.
Modifying
base.py
andlineofsight.py
to make the LGS elongation works do not seem trivial to me.What is your advice or plan here?
Thanks
The text was updated successfully, but these errors were encountered: