Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGS elongation #108

Open
GillesOrban opened this issue Apr 1, 2020 · 1 comment
Open

LGS elongation #108

GillesOrban opened this issue Apr 1, 2020 · 1 comment
Assignees

Comments

@GillesOrban
Copy link

Hi,

LGS elongation does not work when using ShackHartmann and one have to use ShackHartmannLegacy to be able to used it. This is because lineofsight.py and lineofsight_legacy.py diverge significantly.
Not sure what is the idea, what was the motivation to have legacy files, and how much the legacy versions might be outdated.
Modifying base.py and lineofsight.py to make the LGS elongation works do not seem trivial to me.
What is your advice or plan here?
Thanks

@andrewpaulreeves
Copy link
Collaborator

From discussion wiht @ojdf - In the new concept, a new "LineOfSIght" object would be required for each "elongation point" along the LGS beacon. Hopefully this works with the current SH and LOS, and is a bit more elegant internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants