Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_cmd.sh run the UTF-8 tests by default #1903

Closed
wantehchang opened this issue Dec 23, 2023 · 2 comments
Closed

Make test_cmd.sh run the UTF-8 tests by default #1903

wantehchang opened this issue Dec 23, 2023 · 2 comments
Assignees

Comments

@wantehchang
Copy link
Collaborator

Vincent,

I know I asked you to switch to AVIF_TEST_UTF8=0 to skip the UTF-8 tests in test_cmd.sh. When I tried to run the test_cmd.sh script directly rather than through the ctest command, I found that this is a bad idea. Sorry!

The reason is that by default the AVIF_TEST_UTF8 environment variable is not set. So this fails our test in test_cmd.sh:

    if [[ "${AVIF_TEST_UTF8}" == "1" ]]; then

and the UTF-8 tests are not run.

I guess we should go back to what you had originally, AVIF_TEST_NO_UTF8. Thanks.

Note: I wonder if it would be good to rename it AVIF_SKIP_UTF8_TESTS to avoid double negative in the conditional expression:

    if [[ -z "${AVIF_TEST_NO_UTF8}" ]]; then
@wantehchang
Copy link
Collaborator Author

Vincent: My experiments in #1900 showed that it is possible to support all variants of MinGW and get rid of the environment variable AVIF_TEST_UTF8. Perhaps we should try to do that?

@vrabaud
Copy link
Collaborator

vrabaud commented Dec 28, 2023

You are right, your experiment seems to be the best solution, let's go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants