Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could iamf-tool support frame based encoding? #13

Open
yilun-zhangs opened this issue Oct 16, 2024 · 2 comments
Open

Could iamf-tool support frame based encoding? #13

yilun-zhangs opened this issue Oct 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@yilun-zhangs
Copy link

yilun-zhangs commented Oct 16, 2024

@jwcullen

encoder_main_lib.cc
IamfEncoder iamf_encoder(user_metadata);
RETURN_IF_NOT_OK(GenerateObus(
user_metadata, input_wav_directory, output_iamf_directory, iamf_encoder,
ia_sequence_header_obu, codec_config_obus, audio_elements,
mix_presentation_obus, audio_frames, parameter_blocks, arbitrary_obus));

RETURN_IF_NOT_OK(WriteObus(user_metadata, output_iamf_directory,
ia_sequence_header_obu.value(), codec_config_obus,
audio_elements, mix_presentation_obus,
audio_frames, parameter_blocks, arbitrary_obus));

The encoding input is wav file, could it support frame based encoding(input PCM with fixed frame size, e.g. 960)?
regarding live cases, I think frame based encoding is necessary.

@jwcullen
Copy link
Collaborator

Yes, I agree that is needed. It is planned.

@yilun-zhangs
Copy link
Author

Yes, I agree that is needed. It is planned.

Do you have the estimated time to support it?

@jwcullen jwcullen added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants