Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link generated for chroma_sample_position is incorrect #176

Open
wantehchang opened this issue Sep 22, 2023 · 2 comments
Open

Link generated for chroma_sample_position is incorrect #176

wantehchang opened this issue Sep 22, 2023 · 2 comments
Assignees
Labels
editorial if approved, it does not affect the technical aspects of the specification (e.g. typo change)

Comments

@wantehchang
Copy link
Collaborator

This issue was originally reported in #135 (comment).

In the following sentence, the link generated for chroma_sample_position is incorrect:

The <dfn export>chroma_sample_position</dfn> field indicates the [=chroma_sample_position=] value from the [=Sequence Header OBU=].

We want to generate a link to the AV1 spec, but we end up generating a link to the chroma_sample_position term defined in this document.

I tried the following obvious fix, but it doesn't work:

diff --git a/index.bs b/index.bs
index 1eab014..3dc057e 100644
--- a/index.bs
+++ b/index.bs
@@ -108,6 +108,7 @@ url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=44; spec: AV1; ty
 url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=2; spec: AV1; type: dfn;
        text: buffer_removal_time
        text: byte_alignment
+       text: chroma_sample_position
        text: frame_presentation_time
        text: high_bitdepth
        text: initial_display_delay_minus_1

Cyril suggested using a for attribute in the dfn element in #135 (comment). I tried very hard but could not make it work. Hopefully someone more familiar with Bikeshed can figure out a fix.

@cconcolato cconcolato added the editorial if approved, it does not affect the technical aspects of the specification (e.g. typo change) label Nov 27, 2023
@cconcolato cconcolato self-assigned this Jan 22, 2024
@cconcolato
Copy link
Collaborator

Same for twelve_bit and high_bitdepth

@cconcolato
Copy link
Collaborator

We could simply remove the hyperlinks and say "as defined in AV1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial if approved, it does not affect the technical aspects of the specification (e.g. typo change)
Projects
None yet
Development

No branches or pull requests

2 participants