Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup warning seems inaccurate to me #54

Open
rbtcollins opened this issue Nov 16, 2021 · 0 comments
Open

rustup warning seems inaccurate to me #54

rbtcollins opened this issue Nov 16, 2021 · 0 comments

Comments

@rbtcollins
Copy link

Hi, rust-lang/rustup#2028 is the current rustup status around PGP validation. In particular we validate the signature on the channel manifest, and then checksums on every file vs the checksum in the manifest.

While rustup releases are not signed, one could build that once and distributed in a secure fashion within in an organisation if needed; downgrade attacks via channel manifest replacement are possible, IFF (rust infrastructure is compromised || TLS is broken), since the manifests are downloaded from https://static.rust-lang.org.

Certificate pinning: we depend on a defaulted set of GPG keys, included in rustup's source and compiled into the binary. TLS certificate pinning : static.rust-lang.org is using dynamically refreshed certs, making pinning hard. If that changes we can consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant