Check boot mode to validate parameter HostNumber

Identify boot mode of the system using an existing dbus service.
Boot mode for Single Node [2P-Default] is 0 and it is
1 for Multi-Node [2x1P].

Check the URL for resource bios_active and parameter HostNumber.
If the boot mode is Multi-Node [2x1P] and HostNumber is 0,
return an error.
0 is not a valid parameter HostNumber value for the resource
bios_active on Multi-Node [2x1P] systems.

Tested:
Verified on Multi-Node [2x1P] and Single Node [2P-Default] systems.

Signed-off-by: Shirish Pargaonkar <[email protected]>

Author: spargaon

include/bootmode.hpp

@@ -0,0 +1,41 @@
+#pragma once
+
+namespace bootmode
+{
+
+class BootMode {
+private:
+	uint16_t bootMode{0};
+
+	void setBootMode(uint16_t bMode) {bootMode = bMode;};
+public:
+	BootMode() {};
+	BootMode(BootMode const&) = delete;
+	void operator=(BootMode const&) = delete;
+
+	void bootModeService() {
+		crow::connections::systemBus->async_method_call(
+			[this](const boost::system::error_code& ec, sdbusplus::message::message& msg) {
+				if (ec) {
+					BMCWEB_LOG_ERROR("Failed to read CurrentMode: {}", ec);
+					return;
+				}
+
+				std::variant<uint16_t> value;
+				msg.read(value);
+				uint16_t bMode = std::get<uint16_t>(value);
+				BMCWEB_LOG_DEBUG("boot mode: {}", bMode);
+				this->setBootMode(bMode);
+			},
+			"xyz.openbmc_project.Settings",			// service
+			"/xyz/openbmc_project/control/HostMode",	// object path
+			"org.freedesktop.DBus.Properties",		// standard dbus interface
+			"Get",						// method
+			"xyz.openbmc_project.Control.HostMode",		// interface
+			"CurrentMode"					// property
+		);
+	}
+
+	uint16_t getBootMode() const {return bootMode;};
+};
+}

redfish-core/lib/update_service.hpp

@@ -31,6 +31,7 @@
 #include "utils/dbus_utils.hpp"
 #include "utils/json_utils.hpp"
 #include "utils/sw_utils.hpp"
+#include "bootmode.hpp"
 
 #include <sys/mman.h>
 
@@ -67,6 +68,8 @@ static bool fwUpdateInProgress = false;
 // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 static std::unique_ptr<boost::asio::steady_timer> fwAvailableTimer;
 
+extern bootmode::BootMode bmObj;
+
 struct MemoryFileDescriptor
 {
     int fd = -1;
@@ -1386,25 +1389,34 @@ inline void handleUpdateServiceFirmwareInventoryGet(
     }
 
     boost::urls::url_view urlView = req.url();
-    uint16_t hostNumber;
-
-    for (const auto& parameter : urlView.params())
-    {
-        if (parameter.key == "HostNumber" && !parameter.value.empty())
-        {
-            try
-            {
-                int temp = std::stoi(std::string(parameter.value));
-                hostNumber = static_cast<uint16_t>(temp);
-            }
-            catch (const std::exception& e)
-            {
-                BMCWEB_LOG_WARNING("Invalid HostNumber format: {}",
-                                   parameter.value);
-                hostNumber = 0;
-            }
-            break;
-        }
+    uint16_t hostNumber = 0;
+
+    for (const auto& parameter : urlView.params()) {
+	if (parameter.key == "HostNumber") {
+		if (!parameter.value.empty()) {
+			try {
+				int temp = std::stoi(std::string(parameter.value));
+				hostNumber = static_cast<uint16_t>(temp);
+				uint16_t bootMode = bmObj.getBootMode();
+				if (hostNumber == 0 && bootMode == 1) {
+					BMCWEB_LOG_ERROR("Invalid HostNumber {} for the mode {}", hostNumber, bootMode);
+					messages::actionParameterNotSupported(
+						asyncResp->res, std::to_string(hostNumber), "HostNumber");
+					return;
+				}
+			}
+			catch (const std::exception& e) {
+				BMCWEB_LOG_ERROR("Invalid HostNumber format: {}", parameter.value);
+				messages::actionParameterValueFormatError(
+					asyncResp->res, parameter.value, "HostNumber", "");
+				return;
+			}
+		} else {
+			BMCWEB_LOG_ERROR("Missing HostNumber");
+			messages::actionParameterMissing(asyncResp->res, "HostNumber", "");
+			return;
+		}
+	}
     }
 
     if (hostNumber > 2)

redfish-core/src/redfish.cpp

@@ -46,12 +46,18 @@
 #include "trigger.hpp"
 #include "update_service.hpp"
 #include "virtual_media.hpp"
+#include "bootmode.hpp"
 
 namespace redfish
 {
 
+bootmode::BootMode bmObj;
+
 RedfishService::RedfishService(App& app)
 {
+
+    bmObj.bootModeService();
+
     requestRoutesMetadata(app);
 
     requestAccountServiceRoutes(app);