From b6892f7a3bdadbe0b261463bf245ec2263ca98aa Mon Sep 17 00:00:00 2001
From: Dylane Bengono <chaneldylanebengono@gmail.com>
Date: Thu, 19 Sep 2024 14:57:05 +0100
Subject: [PATCH] fix: Update install script to use a temporary directory and
 improve error handling

---
 scripts/install.sh | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/scripts/install.sh b/scripts/install.sh
index 2ee20ca..a8ffce8 100755
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -113,29 +113,46 @@ installation() {
       $PACKAGE_MANAGER update
       WAZUH_MANAGER="$WAZUH_MANAGER" $PACKAGE_MANAGER install wazuh-agent
   elif [ "$OS" = "macOS" ]; then
+      # Detect architecture (Intel or Apple Silicon)
       ARCH=$(uname -m)
       BASE_URL="https://packages.wazuh.com/4.x/macos"
+      
       if [ "$ARCH" = "x86_64" ]; then
-          PKG_NAME="wazuh-agent-4.9.0-1.intel64.pkg"
+          # Intel architecture
+          PKG_NAME="wazuh-agent-4.9.0-1.x86_64.pkg"
       elif [ "$ARCH" = "arm64" ]; then
+          # Apple Silicon (M1/M2)
           PKG_NAME="wazuh-agent-4.9.0-1.arm64.pkg"
       else
-          error_message "Unsupported macOS architecture"
+          error_message "Unsupported architecture: $ARCH"
           exit 1
       fi
+
       PKG_URL="$BASE_URL/$PKG_NAME"
-      TMP_DIR="$(mktemp -d -t wazuh.XXXXXX)"
+
+      # Create a unique temporary directory
+      TMP_DIR=$(mktemp -d 2>/dev/null || mktemp -d -t 'wazuh_install')
       info_message "Using temporary directory: $TMP_DIR"
+
+      # Download the correct Wazuh agent package based on architecture
       curl -o "$TMP_DIR/$PKG_NAME" "$PKG_URL"
       info_message "Wazuh agent downloaded successfully."
+
+      # Set environment variable for Wazuh manager
       echo "WAZUH_MANAGER='$WAZUH_MANAGER'" > /tmp/wazuh_envs
-      sudo installer -pkg "$TMP_DIR/$PKG_NAME" -target /
-      rm -rf "$TMP_DIR"  # Clean up the temporary directory after installation
+
+      # Install Wazuh agent using the package
+      installer -pkg "$TMP_DIR/$PKG_NAME" -target /
+
+      # Clean up the temporary directory after installation
+      rm -rf "$TMP_DIR"
+      info_message "Temporary directory cleaned up."
   fi
   info_message "Wazuh agent installed successfully."
 }
 
 
+
 disable_repo() {
   # Disable Wazuh repository after installation for Linux
   if [ "$OS" = "Linux" ]; then