Correctly set gossip sync_complete #1668
Merged
+44
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are restoring the previous behavior of using the `sync_complete` field to signal the end of a `channel_range_query` sync. The first step is to correctly set that field, before we can read it and interpret it to mark the end of sync. See lightning/bolts#826
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
==========================================
- Coverage 85.95% 85.92% -0.04%
==========================================
Files 151 151
Lines 11457 11460 +3
Branches 484 491 +7
==========================================
- Hits 9848 9847 -1
- Misses 1609 1613 +4
|
sstone
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are restoring the previous behavior of using the
sync_completefield to signal the end of achannel_range_querysync.The first step is to correctly set that field, before we can read it and interpret it to mark the end of sync.
See lightning/bolts#826 for more details.