Improvements and bug fixes for BIP 371 support #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix a bug in the index used for previous inputs - use `InvalidTxOutput` for invalid taproot output fields - add test vectors from BIP 371 - reformat to match the rest of the file Note that I updated the "build and sign a BIP86 psbt" test to include a non-segwit input, this way it fails without the fix to the input index.
t-bast
changed the title
sstone
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes my comments made on #128 and adds a few improvements:
InvalidTxOutputfor invalid taproot output fieldsNote that I updated the "build and sign a BIP86 psbt" test to include a non-segwit input, this way it fails without the fix to the input index.
Note: this is a PR targetting the #128 branch.