Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue this library once Xunit ships its new support for skipping #21

Open
AArnott opened this issue Jul 26, 2020 · 3 comments
Open

Comments

@AArnott
Copy link
Owner

AArnott commented Jul 26, 2020

Xunit itself recently acquired skippable test support: xunit/xunit#2073

Once that ships on nuget.org, we'll shut this repo down.

@irontoby
Copy link

Thanks for calling this out! I'm guessing "official" support will only appear in xUnit v3?

This package has been a big help in our integration tests, and I was looking at extending it to support our specific requirements but based on this it seems it's best to wait until v3 progresses from alpha.

@AArnott
Copy link
Owner Author

AArnott commented Aug 17, 2021

@irontoby Feel free to send issues (and especially PRs) if you're still using xunit v2 and want more functionality. My time is limited but if you are willing to send PRs (preferably after your proposal is ratified via a github issue) I'm happy to keep merging in new functionality.

@perlun
Copy link

perlun commented Jun 6, 2023

In case this helps someone like me: this library is still useful, while we wait for xUnit v3. xunit/xunit#2073 (comment)

(What particularly confuses me is that xUnit v2 Xunit.Sdk.SkipException, but throwing it doesn't properly skip a test...? I guess it's just an internal exception used to implement [Fact(Skip = "...")] in the library or something.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants