Skip to content

Commit da4da1b

Browse files
authored
Update to use Commonmark 2.0 (#12)
* Update to use Commonmark 2.0 * GitHub actions * Initial rendering todo: update markdown files for breaking changes in commonmark html rendering * cleaning house still need to update the markdown files * abbreviation attributes test * attributes and new window not working * Light is green on abbreviations test * Update AbbreviationTest.php * consolidate, refactor, and re-engineer tests * Improve type safety * Create php8.yml * Delete phpunit.xml.bak * remove Shoop dependency * typos
1 parent 6b25eaa commit da4da1b

17 files changed

+689
-394
lines changed

.github/workflows/php.yml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
name: PHP Composer
2-
32
on:
43
push:
54
branches:
@@ -14,13 +13,19 @@ jobs:
1413
runs-on: ubuntu-latest
1514

1615
steps:
17-
- uses: actions/checkout@v2
16+
- name: Checkout
17+
uses: actions/checkout@v2
18+
19+
- name: Setup PHP Action
20+
uses: shivammathur/[email protected]
21+
with:
22+
php-version: '7.4'
1823

1924
- name: Validate composer.json and composer.lock
2025
run: composer validate
2126

22-
# - name: Install dependencies
23-
# run: composer install --prefer-dist --no-progress --no-suggest
27+
- name: Install dependencies
28+
run: composer install --prefer-dist --no-progress --no-suggest
2429

25-
# - name: Run test suite
26-
# run: vendor/bin/phpunit
30+
- name: Run test suite
31+
run: vendor/bin/phpunit

.github/workflows/php8.yml

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
name: PHP Composer
2+
on:
3+
push:
4+
branches:
5+
- master
6+
pull_request:
7+
branches:
8+
- master
9+
10+
jobs:
11+
build:
12+
13+
runs-on: ubuntu-latest
14+
15+
steps:
16+
- name: Checkout
17+
uses: actions/checkout@v2
18+
19+
- name: Setup PHP Action
20+
uses: shivammathur/[email protected]
21+
with:
22+
php-version: '8.0'
23+
24+
- name: Validate composer.json and composer.lock
25+
run: composer validate
26+
27+
- name: Install dependencies
28+
run: composer install --prefer-dist --no-progress --no-suggest
29+
30+
- name: Run test suite
31+
run: vendor/bin/phpunit

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Inspired by the link syntax - `[]()` - and the footnote syntax in the extension
2828

2929
The syntax is a square bracket followed by a period or dot: `[.]()`.
3030

31-
Just like the footnote indcates superscript, the abbreviation syntax was found to indicate shortening to more people than previously proposed options. Placing the dot inside the opening square bracket allows the abbreviation to exist next to other glyphs as opposed to forcing empty space. (A conversation in the [CommonMark [.Spec](Specification) board](https://talk.commonmark.org/t/abbreviations-and-acronyms/890) was also referenced, and informative)
31+
Just like the footnote indicates superscript, the abbreviation syntax was found to indicate shortening to more people than previously proposed options. Placing the dot inside the opening square bracket allows the abbreviation to exist next to other glyphs as opposed to forcing empty space. (A conversation in the [CommonMark [.Spec](Specification) board](https://talk.commonmark.org/t/abbreviations-and-acronyms/890) was also referenced, and informative.)
3232

3333
Given the traditional use of the `abbr` tag commonly combined with the `title` attribute, the link syntax makes sense as the `a` tag combines inner text with `href` and the `img` tag uses two attributes, `src` and `alt` to be valid and accessible.
3434

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111
],
1212
"require": {
1313
"php": "^7.2|^8.0",
14-
"league/commonmark": "~1.5"
14+
"league/commonmark": "~2.0.1"
1515
},
1616
"require-dev": {
17-
"phpunit/phpunit": "^9.1",
18-
"8fold/php-shoop": "^0.10.17@dev"
17+
"phpunit/phpunit": "^9.1"
1918
},
2019
"autoload": {
2120
"psr-4": {

0 commit comments

Comments
 (0)