-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tonemapping: use full 768*512 pic for all examples? #1
Comments
Hmm, I don't think any of the pictures are square. Can you show an example of what you mean? |
That is pretty broken indeed. What browser are you using? |
Happens on Safari 14, Windows Chrome, Windows Firefox, and Mac Chrome 92. Can it be working for you only due to caching? |
I don't think so, it also works just fine on 3-4 different computers and multiple browsers I've tried. I don't think it is a cache problem. Are there any messages in the developer console for you? Does it also happen on your phone? Maybe it is a network / CDN / firewall issue or something, how bizarre. |
Weird, it doesn’t happen on my iPhone! Gonna F12 it… |
Nothing in the console. The "pattern" I am seeing is that the 180x180 pics are coming from The |
Hm, that is odd. It'll probably be fixed if I host the images locally instead; maybe I should just do that. I don't really trust that image hosting site to keep the images indefinitely or remember why I used it in the first place. |
The tonemapping article currently uses square-cropped 180x180 pics for some examples but a full 768x512 pic for others. This is quite nice when put in text, but seems to mess the grid in the conclusion up. It might be a good idea to upload all pics as 768x512 and do a little css to crop them down to squares in text.
(And heck yeah it is good!)
The text was updated successfully, but these errors were encountered: