Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tonemapping: use full 768*512 pic for all examples? #1

Open
Artoria2e5 opened this issue Aug 8, 2021 · 8 comments
Open

tonemapping: use full 768*512 pic for all examples? #1

Artoria2e5 opened this issue Aug 8, 2021 · 8 comments

Comments

@Artoria2e5
Copy link

Artoria2e5 commented Aug 8, 2021

The tonemapping article currently uses square-cropped 180x180 pics for some examples but a full 768x512 pic for others. This is quite nice when put in text, but seems to mess the grid in the conclusion up. It might be a good idea to upload all pics as 768x512 and do a little css to crop them down to squares in text.

(And heck yeah it is good!)

@64
Copy link
Owner

64 commented Aug 17, 2021

Hmm, I don't think any of the pictures are square. Can you show an example of what you mean?

@Artoria2e5
Copy link
Author

On my end it looks like this:
Screen Shot 2021-08-18 at 16 03 00

@64
Copy link
Owner

64 commented Aug 18, 2021

That is pretty broken indeed. What browser are you using?

@Artoria2e5
Copy link
Author

Happens on Safari 14, Windows Chrome, Windows Firefox, and Mac Chrome 92. Can it be working for you only due to caching?

@64
Copy link
Owner

64 commented Aug 18, 2021

I don't think so, it also works just fine on 3-4 different computers and multiple browsers I've tried. I don't think it is a cache problem.

Are there any messages in the developer console for you? Does it also happen on your phone? Maybe it is a network / CDN / firewall issue or something, how bizarre.

@Artoria2e5
Copy link
Author

Weird, it doesn’t happen on my iPhone! Gonna F12 it…

@Artoria2e5
Copy link
Author

Artoria2e5 commented Aug 20, 2021

Nothing in the console. The "pattern" I am seeing is that the 180x180 pics are coming from ibb.co while the full-sized one are coming from i.imgur.com; this also shows in view-source:https://64.github.io/tonemapping/, so I am going to assume JS is not involved.

The ibb.co links are quite... peculiar. If I visit https://i.ibb.co/S6JdvQz/out.png, it redirects me to a webpage that frames the image. If I paste the same link into the address bar again, it gives the full-sized pic...

@64
Copy link
Owner

64 commented Aug 20, 2021

Hm, that is odd. It'll probably be fixed if I host the images locally instead; maybe I should just do that. I don't really trust that image hosting site to keep the images indefinitely or remember why I used it in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants