Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always doing auth redirect when using SessionStorage #52

Open
raucao opened this issue Mar 10, 2020 · 2 comments
Open

Always doing auth redirect when using SessionStorage #52

raucao opened this issue Mar 10, 2020 · 2 comments
Assignees
Labels

Comments

@raucao
Copy link
Member

raucao commented Mar 10, 2020

In Firefox, even though the storage seems to survive page reloads (as intended and documented by Mozilla), it always does the auth redirect for me when reloading the page. Not sure if it's a bug in Firefox or Ember Simple Auth, or Stashboard.

Can someone confirm this?

@raucao raucao added the bug label Mar 10, 2020
@galfert
Copy link
Member

galfert commented Mar 11, 2020

I can confirm the same behaviour in Chrome.

@galfert
Copy link
Member

galfert commented Mar 11, 2020

I think it's a bug in the app itself. When setting SessionStorage as the default session store this doesn't happen.

It's because the app is using localStorage as the default session store and only SessionStorage when the state param on the redirect says so. But when localStorage is empty on app start, it redirects already before checking the SessionStorage for an existing token.

@galfert galfert self-assigned this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants