Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP_SERVER_PORT currently unused #124

Open
Robbilie opened this issue May 4, 2022 · 2 comments · May be fixed by #183
Open

LDAP_SERVER_PORT currently unused #124

Robbilie opened this issue May 4, 2022 · 2 comments · May be fixed by #183
Labels
🐛 bug Something isn't working

Comments

@Robbilie
Copy link
Contributor

Robbilie commented May 4, 2022

LDAP_SERVER_PORT is currently not used and the port and protocol has to be included in the LDAP_SERVER_HOST
the PORT env var has to be set though otherwise an error is thrown

#124 (comment)

@primetheus primetheus added the 🐛 bug Something isn't working label May 5, 2022
@primetheus
Copy link
Collaborator

@Robbilie it looks like we implemented the variables, but only use the LDAP_SERVER_HOST when making the connection. This should be a simple fix. I'll try to get that kicked out this week

@primetheus
Copy link
Collaborator

This line is where the server connection is initialized, so we need to incorporate some pre-init logic to build an ldap3.Server instance and use that instead of the environment variable

@primetheus primetheus linked a pull request Sep 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants