-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: LWC 3.7.0 and QGIS 3.34 raster - symbology #4036
Comments
in case of linear interpolation, not for discrete or exact interpolation |
Similar to qgis/QGIS#55651 ? |
no, only in case of linear interpolation type not for discrete or exact interpolation type |
@josemvm in my LWC 3.7 the color ramp it's not rendered (there isn't a ramp in legend) as in screenshot below in LWC 3.6.9 it seems compressed as in screenshot below so I confirm the Issue |
@Antoviscomi thanks |
Lizmap is taking the JSON legend from QGIS Server, as you can see in the ticket I mentioned earlier. |
@Gustry the url from lizmap doesn´t contain the i can replace the request for myhost/index.php/lizmap/service?repository=ma&project=PIAAC-AC&REQUEST=GetLegendGraphic&FORMAT=image&&SERVICE=WMS&VERSION=1.3.0&FORMAT=image%2Fpng&STYLES=default&TRANSPARENT=true&LAYERS=lst_inv_ac&DPI=96&WIDTH=2080&HEIGHT=475&CRS=EPSG%3A3763&BBOX=-253278.93184485074%2C-179934.01850668347%2C297055.50215735065%2C-54256.68381868075&ts=1707138769681 |
@Gustry here in LWC 3.6.9 the request is: and this it's the result in 3.7 there is not a similar request in browser's 'developer tools' |
There is, check my screenshot, it's a POST request. There must be a |
@Gustry there is not a request |
only in Payload it is, and no response in LWC 3.7 |
In your screenshot, it's the last one. Click one it, you will see in the |
@Gustry
|
There isn't any This JSON is generated by QGIS Server, it's a graphical legend in JSON format. This issue must be reported in QGIS. When QGIS will be fixed, it's high probability that the icon will be displayed in Lizmap Web Client then. |
@Gustry why in LWC 3.6.9 it works? There is not the same request? |
So the bug is quite similar to qgis/QGIS#55651 as I mentioned before. QGIS server is skipping some layers in the JSON representation. |
@Gustry So we could use the |
Yes @josemvm I know this issue, it's unfortunate and I understand... |
Given the work in 3liz/qgis-lizmap-server-plugin#77 we could notice that rendering the raster legend with QGIS < 3.34 is broken. Supporting raster legend 3.7 will only work at least with QGIS 3.34. @josemvm which version are you using ? |
hi @Gustry i'am using qgis server 3.28 |
@Gustry this is the request from LWC 3.7.7 on QGISServer 3.36.2
and this is the result on LWC 3.7.7 Canvas and TOC the legend is now visible but however it seems a little bit small |
Thanks for checking @Antoviscomi |
It's a pleasure @Gustry |
@Gustry i'm sorry, you are right but i had no intention of hurting anyone or devaluing your work or project |
Using QGIS 3.34 is indeed better, but the image provided by QGIS server is too small. |
@Gustry any reason why QGIS server returns (on purpose?) such small raster legend? |
I don't know. Maybe first developed for vector purpose/testing ? According to the PR I made, the GetLegendGraphic JSON was working nicely on QGIS 3.16. Then with LTR 3.22 and 3.28, the JSON was broken, and then on 3.34, the JSON output is back, so no a lot of users on QGIS 3.22 and 3.28 it seems. |
@Gustry not sure I follow: what would be the ideal fix here, patch QGIS Server to generate raster legends with a more reasonable size? |
@Gustry according to my latest experiences, I think the problem lies on LWC and not on qgis server. |
ok, sorry...
|
@josemvm Before LWC 3.7, whatever the version of QGIS server, the format is PNG #4036 (comment) |
@Gustry 3.22(.16) |
@josemvm "Whatever" means "regardless" ;-)
@gioman Yes, being able to set the size of the picture would be better, or at least increase it by default, like the rendering in QGIS Desktop. Doing the tip of @Antoviscomi works, |
@Gustry i meanth that the 'zoom/size' control should acts on the png part only of raster legend served by QGIS Server, obviously if is possible to manage it separately from text part, so that the text part will not deformed |
I'm not sure I understand how the workaround works. |
@gioman I suggest to add a size control in LWC that allow to manage the height/width of png legend served by QGIS server (now the default size readed by LWC is 16x16px, that seems very small) so a control (hardcoded in LWC css i.e.) should permit to well adapts these dimensions |
@Gustry i misinterpreted your affirmation |
maybe an option in the lizmap plugin to GetLegendGraphic as a picture/png, only for lwc 3.7 (?) |
Thanks @Antoviscomi for the correction, indeed, way better ! @josemvm yes, we have talked about that internally. It might be needed maybe for some rendering engine, for like proportional circle. Feel free to contact us. |
Solve 3liz#4036 [Bug]: LWC 3.7.0 and QGIS 3.34 raster - symbology
Thanks @Antoviscomi for the fix |
What is the bug?
qgis desktop 3.22.16
LWC 3.6.8
===========
qgis desktop 3.28.13
LWC 3.7.0
Steps to reproduce the issue
.
Versions
Versions :
List of safeguards :
Check Lizmap plugin
Operating system
Ubuntu 22.04
Browsers
Firefox
Browsers version
Firefox 120.0.1
Relevant log output
No response
The text was updated successfully, but these errors were encountered: