Tests - Upgrade old CFG file having a 3.4 target version

Author: Gustry

assets/src/legacy/map.js

@@ -163,7 +163,6 @@ window.lizMap = function() {
             lizmap_plugin_version_str: "3.1.8",
             lizmap_plugin_version: 30108,
             lizmap_web_client_target_version: 30200,
-            project_valid: null,
             qgis_desktop_version: 30000
         };
 
@@ -176,9 +175,6 @@ window.lizMap = function() {
         if ('lizmap_web_client_target_version' in config['metadata']) {
             plugin_metadata['lizmap_web_client_target_version'] = config['metadata']['lizmap_web_client_target_version'];
         }
-        if ('project_valid' in config['metadata']) {
-            plugin_metadata['project_valid'] = config['metadata']['project_valid'];
-        }
         if ('qgis_desktop_version' in config['metadata']) {
             plugin_metadata['qgis_desktop_version'] = config['metadata']['qgis_desktop_version'];
         }

assets/src/modules/config/Metadata.js

@@ -9,7 +9,6 @@ import { BaseObjectConfig } from './BaseObject.js';
 
 const optionalProperties = {
     'lizmap_web_client_target_version': {type: 'number', default: 30200},
-    'project_valid': {type: 'boolean', nullable: true, default: null},
     'qgis_desktop_version': {type: 'null', default: 30000}
 };
 
@@ -26,7 +25,6 @@ export class MetadataConfig extends BaseObjectConfig {
      * @param {string}  [cfg.lizmap_plugin_version]                  - the lizmap plugin version as number used to configure the project
      * @param {string}  [cfg.lizmap_plugin_version_str]              - the lizmap plugin version as string used to configure the project
      * @param {number}  [cfg.lizmap_web_client_target_version] - the target lizmap web client version as integer
-     * @param {boolean} [cfg.project_valid]                          - Is the project valid ?
      * @param {number}  [cfg.qgis_desktop_version]             - the QGIS Desktop version as integer used to build the project
      */
     constructor(cfg = {}) {
@@ -89,14 +87,6 @@ export class MetadataConfig extends BaseObjectConfig {
     }
 
 
-    /**
-     * Is the project valid ?
-     * @type {?boolean}
-     */
-    get project_valid() {
-        return this._project_valid;
-    }
-
     /**
      * The QGIS Desktop version as integer used to build the project
      * @type {number}

lizmap/modules/lizmap/lib/Project/ProjectConfig.php

@@ -676,7 +676,7 @@ private function parseDatavizTreeNode($node, $level, $debug)
      * Get the metadata written by Lizmap plugin
      * about the desktop version used.
      * qgis_desktop_version, lizmap_plugin_version,
-     * lizmap_web_client_target_version, project_valid.
+     * lizmap_web_client_target_version.
      *
      * @return null|object
      */

tests/end2end/cypress/integration/requests-getprojectconfig-ghaction.js

@@ -13,7 +13,6 @@ describe('Request Lizmap GetProjectConfig', function () {
             expect(resp.body.metadata).to.have.property('lizmap_plugin_version')
             expect(resp.body.metadata).to.have.property('lizmap_plugin_version_str')
             expect(resp.body.metadata).to.have.property('lizmap_web_client_target_version')
-            expect(resp.body.metadata).to.have.property('project_valid')
             expect(resp.body.metadata).to.have.property('qgis_desktop_version')
 
             expect(resp.body).to.have.property('options')

tests/js-units/data/backgrounds-config.json

@@ -827,8 +827,7 @@
         "lizmap_web_client_target_version": 30700,
         "lizmap_web_client_target_status": "Dev",
         "instance_target_url": "https://demo.snap.lizmap.com/lizmap_3_7/",
-        "instance_target_repository": "features",
-        "project_valid": true
+        "instance_target_repository": "features"
     },
     "options": {
         "projection": {

tests/js-units/data/cadastre-caen-config.json

@@ -1183,8 +1183,7 @@
         "lizmap_plugin_version": 31400,
         "lizmap_web_client_target_version": 30500,
         "lizmap_web_client_target_status": "Stable",
-        "instance_target_url": "https://demo.lizmap.com/lizmap_3_5/",
-        "project_valid": false
+        "instance_target_url": "https://demo.lizmap.com/lizmap_3_5/"
     },
     "options": {
         "projection": {

tests/js-units/data/layer_order-config.json

@@ -202,8 +202,7 @@
         "lizmap_web_client_target_version": 30700,
         "lizmap_web_client_target_status": "Dev",
         "instance_target_url": "http://localhost:8130/",
-        "instance_target_repository": "intranet",
-        "project_valid": true
+        "instance_target_repository": "intranet"
     },
     "options": {
         "projection": {

tests/js-units/data/montpellier-config.json

@@ -1213,8 +1213,7 @@
   "metadata": {
     "qgis_desktop_version": 31615,
     "lizmap_plugin_version": "3.7.7",
-    "lizmap_web_client_target_version": 30500,
-    "project_valid": true
+    "lizmap_web_client_target_version": 30500
   },
   "options": {
     "projection": {

tests/js-units/data/mutually-exclusive-config.json

@@ -128,8 +128,7 @@
     "metadata": {
       "qgis_desktop_version": 32205,
       "lizmap_plugin_version": "master",
-      "lizmap_web_client_target_version": 30500,
-      "project_valid": true
+      "lizmap_web_client_target_version": 30500
     },
     "options": {
       "projection": {

tests/js-units/node/config/metadata.test.js

@@ -8,7 +8,6 @@ describe('MetadataConfig', function () {
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.1.8')
         expect(mt.lizmap_plugin_version).to.be.eq(30108)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30200)
-        expect(mt.project_valid).to.be.eq(null)
         expect(mt.qgis_desktop_version).to.be.eq(30000)
     })
 
@@ -23,21 +22,18 @@ describe('MetadataConfig', function () {
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.8.1')
         expect(mt.lizmap_plugin_version).to.be.eq(30801)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30503)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(32200)
     })
 
     it('events.qgs.cfg metadata', function () {
         const mt = new MetadataConfig({
             "qgis_desktop_version": 31615,
             "lizmap_plugin_version": "3.7.7",
-            "lizmap_web_client_target_version": 30500,
-            "project_valid": true
+            "lizmap_web_client_target_version": 30500
         });
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.7.7')
         expect(mt.lizmap_plugin_version).to.be.eq(30707)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30500)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(31615)
     })
 
@@ -47,13 +43,11 @@ describe('MetadataConfig', function () {
             "lizmap_plugin_version_str": "3.9.1",
             "lizmap_plugin_version": 30901,
             "lizmap_web_client_target_version": 30500,
-            "lizmap_web_client_target_status": "Stable",
-            "project_valid": true
+            "lizmap_web_client_target_status": "Stable"
         });
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.9.1')
         expect(mt.lizmap_plugin_version).to.be.eq(30901)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30500)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(32211)
     })
 
@@ -64,27 +58,23 @@ describe('MetadataConfig', function () {
             "lizmap_plugin_version": 31301,
             "lizmap_web_client_target_version": 30700,
             "lizmap_web_client_target_status": "Dev",
-            "instance_target_url": "http://localhost:8130/",
-            "project_valid": true
+            "instance_target_url": "http://localhost:8130/"
         });
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.13.1-alpha')
         expect(mt.lizmap_plugin_version).to.be.eq(31301)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30700)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(32216)
     })
 
     it('stratup.qgs.cfg metadata', function () {
         const mt = new MetadataConfig({
             "qgis_desktop_version": 31615,
             "lizmap_plugin_version": "3.7.8-pre",
-            "lizmap_web_client_target_version": 30500,
-            "project_valid": true
+            "lizmap_web_client_target_version": 30500
         });
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.7.8-pre')
         expect(mt.lizmap_plugin_version).to.be.eq(30708)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30500)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(31615)
     })
 
@@ -96,21 +86,18 @@ describe('MetadataConfig', function () {
         expect(mt.lizmap_plugin_version_str).to.be.eq('3.2.18')
         expect(mt.lizmap_plugin_version).to.be.eq(30218)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30300)
-        expect(mt.project_valid).to.be.null
         expect(mt.qgis_desktop_version).to.be.eq(30000)
     })
 
     it('dnd_form.qgs.cfg metadata', function () {
         const mt = new MetadataConfig({
             "qgis_desktop_version": 32204,
             "lizmap_plugin_version": "master",
-            "lizmap_web_client_target_version": 30500,
-            "project_valid": true
+            "lizmap_web_client_target_version": 30500
         });
         expect(mt.lizmap_plugin_version_str).to.be.eq('master')
         expect(mt.lizmap_plugin_version).to.be.eq(999999)
         expect(mt.lizmap_web_client_target_version).to.be.eq(30500)
-        expect(mt.project_valid).to.be.true
         expect(mt.qgis_desktop_version).to.be.eq(32204)
     })
 })