From 7a5b384cca01e6064283272a5efe70922d4a7c63 Mon Sep 17 00:00:00 2001 From: 1ikeadragon <1ikeadragon@noskill.agency> Date: Mon, 18 Nov 2024 15:01:15 +0530 Subject: [PATCH 1/3] Added F4 keybinding for action Run To Here. --- ui/ui.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/ui.cpp b/ui/ui.cpp index 386c357..dc3a53b 100644 --- a/ui/ui.cpp +++ b/ui/ui.cpp @@ -517,7 +517,7 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context) }, connectedAndStoppedWithTTD)); - UIAction::registerAction("Run To Here"); + UIAction::registerAction("Run To Here", QKeySequence(Qt::Key_F4)); context->globalActions()->bindAction("Run To Here", UIAction( [=](const UIActionContext& ctxt) { From d360ce1ea53d8a18d3b13a38509115962efc5e56 Mon Sep 17 00:00:00 2001 From: Xusheng Date: Thu, 21 Nov 2024 10:54:44 +0800 Subject: [PATCH 2/3] Fix docs on asynchronous API. Fix https://github.com/Vector35/debugger/issues/665 --- api/python/debuggercontroller.py | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/api/python/debuggercontroller.py b/api/python/debuggercontroller.py index 600ecae..709d4f1 100644 --- a/api/python/debuggercontroller.py +++ b/api/python/debuggercontroller.py @@ -823,7 +823,7 @@ def go(self) -> bool: The call is asynchronous and returns before the target stops. - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerGo(self.handle) @@ -834,7 +834,7 @@ def go_reverse(self) -> bool: The call is asynchronous and returns before the target stops. - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerGoReverse(self.handle) @@ -855,7 +855,7 @@ def step_into(self, il: binaryninja.FunctionGraphType = binaryninja.FunctionGrap The call is asynchronous and returns before the target stops. :param il: optional IL level to perform the operation at - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepInto(self.handle, il) @@ -876,7 +876,7 @@ def step_into_reverse(self, il: binaryninja.FunctionGraphType = binaryninja.Func The call is asynchronous and returns before the target stops. :param il: optional IL level to perform the operation at - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepIntoReverse(self.handle, il) @@ -897,7 +897,7 @@ def step_over(self, il: binaryninja.FunctionGraphType = binaryninja.FunctionGrap The call is asynchronous and returns before the target stops. :param il: optional IL level to perform the operation at - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepOver(self.handle, il) @@ -918,7 +918,7 @@ def step_over_reverse(self, il: binaryninja.FunctionGraphType = binaryninja.Func The call is asynchronous and returns before the target stops. :param il: optional IL level to perform the operation at - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepOverReverse(self.handle, il) @@ -938,7 +938,7 @@ def step_return(self) -> bool: The call is asynchronous and returns before the target stops. - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepReturn(self.handle) @@ -958,7 +958,7 @@ def step_return_reverse(self) -> bool: The call is asynchronous and returns before the target stops. - :return: the reason for the stop + :return: whether the operation is successfully requested """ return dbgcore.BNDebuggerStepReturnReverse(self.handle) @@ -971,8 +971,9 @@ def run_to(self, address) -> bool: Internally, the debugger places breakpoints on these addresses, resume the target, and wait for the target to break. Then the debugger removes the added breakpoints. - The call is asynchronous and returns before the target stops. + The call is asynchronous and returns before the target stops. + :return: whether the operation is successfully requested """ if isinstance(address, int): address = [address] @@ -1125,6 +1126,7 @@ def run_to_and_wait(self, address) -> DebugStopReason: The call is blocking and only returns when the target stops. + :return: the reason for the stop """ if isinstance(address, int): address = [address] From b713062fd893d8980ec372025d9dd6e8b85ee7f1 Mon Sep 17 00:00:00 2001 From: Brian Potchik Date: Thu, 21 Nov 2024 15:33:52 -0500 Subject: [PATCH 3/3] Remove DockHandler and DockWidget support. --- ui/breakpointswidget.h | 1 - ui/debuggerinfowidget.h | 1 - ui/moduleswidget.h | 1 - ui/registerswidget.h | 1 - ui/stackwidget.h | 1 - ui/statusbar.h | 1 - 6 files changed, 6 deletions(-) diff --git a/ui/breakpointswidget.h b/ui/breakpointswidget.h index 9be5cba..935105f 100644 --- a/ui/breakpointswidget.h +++ b/ui/breakpointswidget.h @@ -23,7 +23,6 @@ limitations under the License. #include #include "inttypes.h" #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "theme.h" diff --git a/ui/debuggerinfowidget.h b/ui/debuggerinfowidget.h index 035abd2..9ec4bfe 100644 --- a/ui/debuggerinfowidget.h +++ b/ui/debuggerinfowidget.h @@ -23,7 +23,6 @@ limitations under the License. #include #include "inttypes.h" #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "theme.h" diff --git a/ui/moduleswidget.h b/ui/moduleswidget.h index 110c657..a97b378 100644 --- a/ui/moduleswidget.h +++ b/ui/moduleswidget.h @@ -23,7 +23,6 @@ limitations under the License. #include #include "inttypes.h" #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "theme.h" diff --git a/ui/registerswidget.h b/ui/registerswidget.h index 02da65c..ed4ce05 100644 --- a/ui/registerswidget.h +++ b/ui/registerswidget.h @@ -24,7 +24,6 @@ limitations under the License. #include #include "inttypes.h" #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "theme.h" diff --git a/ui/stackwidget.h b/ui/stackwidget.h index d9305cc..8e5dc3c 100644 --- a/ui/stackwidget.h +++ b/ui/stackwidget.h @@ -23,7 +23,6 @@ limitations under the License. #include #include "inttypes.h" #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "theme.h" diff --git a/ui/statusbar.h b/ui/statusbar.h index 66d2bc7..62e51c4 100644 --- a/ui/statusbar.h +++ b/ui/statusbar.h @@ -23,7 +23,6 @@ limitations under the License. #include #include #include "binaryninjaapi.h" -#include "dockhandler.h" #include "viewframe.h" #include "fontsettings.h" #include "debuggerapi.h"