From 90c0a5fb704f5cc01acef9df2c0af69978e078aa Mon Sep 17 00:00:00 2001
From: Xusheng <xusheng@vector35.com>
Date: Mon, 20 Mar 2023 14:27:49 +0800
Subject: [PATCH] Avoid UAF in attach process dialog

---
 ui/attachprocess.cpp  | 1 -
 ui/controlswidget.cpp | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/ui/attachprocess.cpp b/ui/attachprocess.cpp
index 511486a8..21bacdb7 100644
--- a/ui/attachprocess.cpp
+++ b/ui/attachprocess.cpp
@@ -352,7 +352,6 @@ AttachProcessDialog::AttachProcessDialog(QWidget* parent, DbgRef<DebuggerControl
 {
 	setWindowTitle("Attach to process");
 	setMinimumSize(UIContext::getScaledWindowSize(450, 600));
-	setAttribute(Qt::WA_DeleteOnClose);
 	setSizeGripEnabled(true);
 	setModal(true);
 
diff --git a/ui/controlswidget.cpp b/ui/controlswidget.cpp
index 58227270..05fa1be7 100644
--- a/ui/controlswidget.cpp
+++ b/ui/controlswidget.cpp
@@ -146,11 +146,11 @@ void DebugControlsWidget::performLaunch()
 
 void DebugControlsWidget::performAttachPID()
 {
-	auto dialog = new AttachProcessDialog(this, m_controller);
-	if (dialog->exec() != QDialog::Accepted)
+	AttachProcessDialog dialog(this, m_controller);
+	if (dialog.exec() != QDialog::Accepted)
 		return;
 
-	uint32_t pid = dialog->GetSelectedPid();
+	uint32_t pid = dialog.GetSelectedPid();
 	if (pid == 0)
 		return;