Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$HAM tokens cannot be purchased on 1BCH DEX #2

Open
ElDoradoTG opened this issue Dec 12, 2021 · 6 comments
Open

$HAM tokens cannot be purchased on 1BCH DEX #2

ElDoradoTG opened this issue Dec 12, 2021 · 6 comments

Comments

@ElDoradoTG
Copy link

ElDoradoTG commented Dec 12, 2021

Dear DEVs,

I noticed that our $HAM cannot be purchased (any amount, 10,000 - 1 tokens) on the 1BCH DEX.

Each time the following error is displayed "The transaction cannot succeed due to error: invalid opcode. Please go to transfer settings icon upper right corner and increase slippage to 10% or more (depending on liquidity of pair). Therefore, especially for relative small liquidity cases, please either: increase slippage > 10% or make multiple smaller trades instead".

Switching between "Disable Multihops" ON / OFF does not make a difference, as with each setting the above listed error is displayed.

Furthermore the advice to use a slippage of 10% or more is highly unwanted & dangerous.

@ElDoradoTG ElDoradoTG changed the title @=$HAM tokens cannot be purchased on 1BCH DEX $HAM tokens cannot be purchased on 1BCH DEX Dec 12, 2021
@1BCHDev1
Copy link
Contributor

that is strange as it seams to be working when testing in one direction, see the recent test transaction: https://www.smartscan.cash/transaction/0x4f4001cf7b1cec0eef9b98ca0e65a97a3d0aaef2fae0d4609d096e09f912f178

i.e. swap an exact amount to xxx works (enter a value in the top field)
but i coudl reproduce the otehr way around swap xxx for exact amount (enter a exact value in the bottom field)

for now please just use the top field, we are working on finding out what's wrong with the otehr direction

@1BCHDev1
Copy link
Contributor

We have found the issue and will deploy a fix tomorow.

@ElDoradoTG
Copy link
Author

Excellent. Looking forward to the fix.

@ElDoradoTG
Copy link
Author

Please note: Also change / fix the error warning text, as the advice to use a slippage of 10% or more is highly unwanted & dangerous.

@1BCHDev1
Copy link
Contributor

1BCHDev1 commented Dec 13, 2021

The issue has been fixed, by deploying a updated router contract, also the error warning text was shortened to the error only with out advice what to do.
Please confirm that is working for you now.

@ElDoradoTG
Copy link
Author

I can confirm that both ways (selling / buying) is functional. Thanks a lot for the fix, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants