Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to notification messages when settings are saved #837

Open
1 task done
dkotter opened this issue Dec 20, 2024 · 4 comments · May be fixed by #838
Open
1 task done

Scroll to notification messages when settings are saved #837

dkotter opened this issue Dec 20, 2024 · 4 comments · May be fixed by #838
Assignees
@iamdharmesh
Labels
type:enhancement New feature or request.
Milestone
3.3.0

Comments

@dkotter
Copy link
Collaborator

dkotter commented Dec 20, 2024

Is your enhancement related to a problem? Please describe.

With the new settings UI that was launched in v3.2.0, we no longer have page refreshes when settings are saved. What this means though is on longer settings pages, when someone saves, they have to scroll up manually to see the notification message. This makes it hard to know if things saved successfully or if something went wrong.

I can see two approaches here:

  1. Show these messages closer to the save button
  2. Automatically scroll up to the message when a save happens

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:enhancement New feature or request. label Dec 20, 2024
@dkotter dkotter added this to the 3.3.0 milestone Dec 20, 2024
@dkotter
Copy link
Collaborator Author

dkotter commented Dec 20, 2024

And I guess testing further, we don't actually show a success message, just error messages. Seems we should show some sort of success indicator to make it clear things worked

@vikrampm1 vikrampm1 moved this from Incoming to Backlog in Open Source Practice Dec 20, 2024
@jeffpaul
Copy link
Member

What about using a similar snackbar message like is shown within the editor? (that bottom left black background and white text component)

@iamdharmesh
Copy link
Member

We previously had a long "Save Settings" button with a processing UI, so we decided not to show a success notification. However, with the updated UI, displaying a notification with a snackbar message is now the most appropriate approach.

@iamdharmesh iamdharmesh self-assigned this Dec 23, 2024
@iamdharmesh iamdharmesh linked a pull request Dec 23, 2024 that will close this issue
Open
4 tasks
@jeffpaul jeffpaul moved this from Backlog to Code Review in Open Source Practice Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamdharmesh iamdharmesh

Labels
type:enhancement New feature or request.
Projects
Open Source Practice
Status: Code Review
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Add a Snackbar notice to inform users that settings have been saved successfully. 10up/classifai
4 participants
@dkotter @jeffpaul @iamdharmesh and others