Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old feature settings code #3746

Open
1 task done
JakePT opened this issue Nov 1, 2023 · 0 comments
Open
1 task done

Clean up old feature settings code #3746

JakePT opened this issue Nov 1, 2023 · 0 comments

Comments

@JakePT
Copy link
Contributor

JakePT commented Nov 1, 2023

Is your enhancement related to a problem? Please describe.

The new features screen uses settings_schema and the get_json method of the Feature class. Code for the old settings page should probably be removed and/or deprecated. This includes:

  • Feature::output_feature_box_summary
  • Feature::output_feature_box_long
  • Feature::output_feature_box
  • Feature::output_feature_box_settings
  • Feature::output_settings_box
  • Feature::get_epio_logo
  • Features::update_feature
  • Anything hooked to ep_sanitize_feature_settings
  • assets/js/instant-results/admin
  • Anything in assets/js/dashboard.js related to feature settings.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JakePT JakePT added this to the 5.1.0 milestone Nov 1, 2023
@felipeelia felipeelia modified the milestones: 5.1.0, 5.2.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants