[FEATURE] Ajout d'un bouton reload pour les embed (PIX-15418) #10784
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
aurelie-crouillebois
changed the title
rouxxi
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
rouxxi
force-pushed
the
pix-15418-add-restart-to-junior-embed
branch
from
e8c8a01 to
215597c
Compare
|
Test func OK ✅ |
mcampourcy
added
Func Review OK
mcampourcy
approved these changes
Dec 13, 2024
aurelie-crouillebois
approved these changes
Dec 13, 2024
|
nickel mais peut-on ajouter de la marge entre l'icone et le texte en appliquant le style tertiary du button de Pix UI ?(https://ui.pix.fr/?path=/docs/actions-button--docs) |
rouxxi
force-pushed
the
pix-15418-add-restart-to-junior-embed
branch
from
215597c to
40931a1
Compare
aurelie-crouillebois
added
Design Review OK
🚀 Ready to Merge
and removed
👀 Design Review Needed
labels
pix-service-auto-merge
force-pushed
the
pix-15418-add-restart-to-junior-embed
branch
from
40931a1 to
e39959c
Compare
pix-service-auto-merge
deleted the
pix-15418-add-restart-to-junior-embed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Les utilisateurs ne peuvent pas reload l'embed sans recharger la page.
🎁 Proposition
Ajout d'un bouton "Recommencer" en dessous des embeds avant validation.
🧦 Remarques
RAS
🎅 Pour tester
Ce boutton ne doit pas s'afficher sur des carrousel / QCU_Image / etc...
Possible de tester avec un simulateur qui doit avoir le bouton de reload => https://junior-pr10784.review.pix.fr/challenges/challenge1JkmTl7OQTiW4z/preview
Lors de la validation il faut que le boutton soit caché