Skip to content

Commit 0cb87a4

Browse files
style(junior): optimize challenge page to avoid scrolling
1 parent 8cdcdf5 commit 0cb87a4

File tree

6 files changed

+25
-13
lines changed

6 files changed

+25
-13
lines changed

junior/app/components/robot-dialog.gjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { tracked } from '@glimmer/tracking';
44

55
import didRender from '../modifiers/did-render';
66

7-
const ROBOT_IMAGE_OFFSET = 76;
7+
const ROBOT_IMAGE_OFFSET = 68;
88

99
export default class RobotDialog extends Component {
1010
@tracked resizeObserver;

junior/app/styles/app.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ b {
4848
max-width: 1730px;
4949

5050
@include device-is('tablet') {
51-
margin: 32px;
51+
margin: 24px;
5252
}
5353

5454
@include device-is('desktop') {

junior/app/styles/components/bubble.scss

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.bubble-container {
22
display: flex;
3-
margin-bottom: 16px;
3+
margin-bottom: 8px;
44
}
55

66
.bubble {
@@ -9,8 +9,13 @@
99
height: fit-content;
1010
margin-right: 16px;
1111
margin-left: 8px;
12-
padding: 12px 24px;
13-
font-size: 1.5rem;
12+
padding: 8px 20px;
13+
font-size: 1.4rem;
14+
15+
@include device-is('tablet') {
16+
font-size: 1.25rem;
17+
}
18+
1419
text-align: left;
1520
background-color: var(--pix-primary-100);
1621
border-radius: 16px 16px 16px 0;

junior/app/styles/components/challenge/challenge-item.scss

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
.challenge-item {
22
display: flex;
33
align-content: center;
4-
margin: 35px 140px 0;
4+
margin: 16px 140px 0;
55
transition: all 0.4s;
66

77
@include device-is('tablet') {
8-
margin: 35px 120px 0;
8+
margin: 16px 120px 0;
99
}
1010

1111
&--single-display {
1212
flex-direction: column;
1313
}
1414

1515
&__media {
16-
width: 60%;
16+
width: 50%;
1717
height: fit-content;
1818
margin-right: var(--pix-spacing-6x);
1919
padding: var(--pix-spacing-4x);
@@ -28,7 +28,7 @@
2828
}
2929

3030
&__proposals {
31-
width: 40%;
31+
width: 50%;
3232

3333
&--single-display {
3434
width: unset;

junior/app/styles/components/robot-dialog.scss

+10-4
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,32 @@
11
.robot-speaking {
22
display: flex;
33
width: 100%;
4-
margin-top: 30px;
4+
margin-top: 24px;
5+
6+
@include device-is('tablet') {
7+
margin-top: 12px;
8+
}
59

610
.bubbles {
711
display: flex;
812
flex-direction: column;
913
justify-content: start;
1014
max-width: 80%;
11-
margin-left: 130px;
15+
margin-left: 140px;
16+
17+
@include device-is('tablet') {
18+
margin-left: 120px;
19+
}
1220
}
1321

1422
&__logo {
1523
position: absolute;
1624
width: 128px;
1725
margin-top: -57px;
18-
margin-right: var(--pix-spacing-3x);
1926

2027
@include device-is('tablet') {
2128
width: 106px;
2229
margin-top: -37px;
23-
margin-right: var(--pix-spacing-4x);
2430
}
2531
}
2632
}

junior/app/styles/pages/identified/missions/mission.scss

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.mission-page {
22
&__body {
33
display: flex;
4+
margin-top: 16px;
45
margin-left: 145px;
56

67
@include device-is('tablet') {

0 commit comments

Comments
 (0)