Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression ratio is slightly worse than in Pako #224

Open
mimi89999 opened this issue Sep 28, 2024 · 1 comment
Open

Compression ratio is slightly worse than in Pako #224

mimi89999 opened this issue Sep 28, 2024 · 1 comment

Comments

@mimi89999
Copy link

Hello,

I took the dist/zxcvbn-ts.js file from the https://www.npmjs.com/package/@zxcvbn-ts/language-pl/v/4.0.0-beta.0 and compressed it with fflate and Pako with level 9.
With fflate I got: zxcvbn-ts.js compressed from 821.1 kB to 374.3 kB
With Pako I got: zxcvbn-ts.js compressed from 821.1 kB to 352.0 kB

That's a difference of about 6%. It's small, but still noticeable.

@101arrowz
Copy link
Owner

This is probably expected behavior given differences in the algorithm implementation between Pako and fflate. You are right that 6% is larger than usual though, it's worth looking into why this is (once I can find more time to do maintenance on this project!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants