From 6c49b406f79fb716ac889127c6a9476c69f36396 Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Mon, 17 Jun 2024 12:34:16 +0530 Subject: [PATCH 01/20] Make the diagnostic button visible again Signed-off-by: Aniket Kadam --- room-kit/src/main/res/layout/fragment_preview.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/room-kit/src/main/res/layout/fragment_preview.xml b/room-kit/src/main/res/layout/fragment_preview.xml index 44a7317a7..6334e87f0 100644 --- a/room-kit/src/main/res/layout/fragment_preview.xml +++ b/room-kit/src/main/res/layout/fragment_preview.xml @@ -95,7 +95,6 @@ android:elevation="@dimen/eight_dp" app:contentPadding="@dimen/eight_dp" android:src="@drawable/icon" - android:visibility="invisible" android:padding="0.5dp" app:layout_constraintRight_toRightOf="parent" app:layout_constraintTop_toTopOf="parent" From cdccae6d7daa3a30ff88b995db9986afac1fd606 Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Tue, 18 Jun 2024 15:27:52 +0530 Subject: [PATCH 02/20] Allow CQS to be crossed out at null Signed-off-by: Aniket Kadam --- .../live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt | 1 + .../diagnostic/fragments/PreCallConnectivityTestFragment.kt | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt index c50467dcd..56d2005fd 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt @@ -129,6 +129,7 @@ class DiagnosticViewModel(application: Application) : AndroidViewModel(applicati isMediaPublished= false isMediaCaptured = false connectivityLiveData.postValue(null) + connectivityStateLiveData.postValue(null) diagnosticSDK.startConnectivityCheck(regionCode, object : live.hms.video.diagnostics.ConnectivityCheckListener { override fun onCompleted(result: ConnectivityCheckResult) { diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index 5a075e836..0cc914f31 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -161,8 +161,8 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "CQS", - "${if (model.mediaServerReport.connectionQualityScore == null) 0 else model.mediaServerReport.connectionQualityScore} / 5", - R.drawable.ic_correct_tick_small + "${model.mediaServerReport.connectionQualityScore ?: 0} / 5", + if((model.mediaServerReport.connectionQualityScore ?: 0) == 0) R.drawable.ic_correct_tick_small else R.drawable.ic_cross_small ) ) } From 9307a0bf1d876c81d545dd3ad1822e948849f501 Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Tue, 18 Jun 2024 15:35:56 +0530 Subject: [PATCH 03/20] Fix reversed cqs Signed-off-by: Aniket Kadam --- .../ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index 0cc914f31..985c4396d 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -162,7 +162,7 @@ class PreCallConnectivityTestFragment : Fragment() { DiagnosticDetail( "CQS", "${model.mediaServerReport.connectionQualityScore ?: 0} / 5", - if((model.mediaServerReport.connectionQualityScore ?: 0) == 0) R.drawable.ic_correct_tick_small else R.drawable.ic_cross_small + if((model.mediaServerReport.connectionQualityScore ?: 0) == 0) R.drawable.ic_cross_small else R.drawable.ic_correct_tick_small ) ) } From 608f1bf959c209fe0e9823dd5d11f343c369e468 Mon Sep 17 00:00:00 2001 From: pratimmallick Date: Tue, 18 Jun 2024 17:32:56 +0530 Subject: [PATCH 04/20] formatted bytes sent and received --- .../diagnostic/fragments/PreCallConnectivityTestFragment.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index 85c92dc4a..45f142db7 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -28,6 +28,7 @@ import live.hms.roomkit.ui.diagnostic.item.Padding import live.hms.roomkit.ui.theme.applyTheme import live.hms.roomkit.ui.theme.buttonEnabled import live.hms.roomkit.util.viewLifecycle +import live.hms.stats.Utils import live.hms.video.diagnostics.models.ConnectivityCheckResult import live.hms.video.diagnostics.models.ConnectivityState @@ -188,7 +189,7 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Bytes Received", - "${videoStats?.bytesReceived ?: 0}", + Utils.humanReadableByteCount(videoStats?.bytesReceived ?: 0, true, false), R.drawable.ic_correct_tick_small ) ) @@ -246,7 +247,7 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Bytes Received", - "${audioStats?.bytesReceived ?: 0}", + Utils.humanReadableByteCount(audioStats?.bytesReceived ?: 0, true, false), R.drawable.ic_correct_tick_small ) ) From 9ae03ef12da18990822ef121b3e1a93d22cd5181 Mon Sep 17 00:00:00 2001 From: Gulzar Date: Wed, 19 Jun 2024 13:29:09 +0530 Subject: [PATCH 05/20] added changes --- .../java/live/hms/app2/ui/home/HomeFragment.kt | 6 ++++++ app/src/main/res/drawable/ic_diagnostic_blue.xml | 10 ++++++++++ app/src/main/res/layout/fragment_home.xml | 15 +++++++++++++++ app/src/main/res/values/strings.xml | 1 + .../roomkit/ui/diagnostic/DiagnosticActivity.kt | 4 ++++ .../java/live/hms/roomkit/ui/theme/ThemeExt.kt | 2 +- 6 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 app/src/main/res/drawable/ic_diagnostic_blue.xml diff --git a/app/src/main/java/live/hms/app2/ui/home/HomeFragment.kt b/app/src/main/java/live/hms/app2/ui/home/HomeFragment.kt index 4b7d891be..e7a1a47bf 100644 --- a/app/src/main/java/live/hms/app2/ui/home/HomeFragment.kt +++ b/app/src/main/java/live/hms/app2/ui/home/HomeFragment.kt @@ -192,6 +192,12 @@ class HomeFragment : Fragment() { validate() } + binding.troubleshoot.setOnClickListener { + contextSafe { context, activity -> + HMSRoomKit.launchPreCallDiagnostic(activity) + } + } + binding.edtMeetingUrl.doOnTextChanged { text, _, _, _ -> if (text.isNullOrEmpty()) { binding.tvMeetingUrlInputLayout.hint = diff --git a/app/src/main/res/drawable/ic_diagnostic_blue.xml b/app/src/main/res/drawable/ic_diagnostic_blue.xml new file mode 100644 index 000000000..0894e76f6 --- /dev/null +++ b/app/src/main/res/drawable/ic_diagnostic_blue.xml @@ -0,0 +1,10 @@ + + + diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index b1dd98384..a2b8531ee 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -49,6 +49,21 @@ android:orientation="vertical"> android:textColor="#E0ECFF" android:textSize="16sp" /> + + Paste the link here Joining Link Jump right in by pasting a room link or scanning a QR code + Troubleshoot before you join Experience the power of 100ms Join with Link Instead Scan QR Code diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticActivity.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticActivity.kt index f9903805d..c7e58fa8c 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticActivity.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticActivity.kt @@ -9,6 +9,7 @@ import androidx.navigation.fragment.findNavController import live.hms.roomkit.R import live.hms.roomkit.ui.meeting.MeetingViewModel import live.hms.roomkit.ui.meeting.MeetingViewModelFactory +import live.hms.roomkit.ui.theme.HMSPrebuiltTheme class DiagnosticActivity : AppCompatActivity() { @@ -21,6 +22,9 @@ class DiagnosticActivity : AppCompatActivity() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) setContentView(R.layout.activity_diagnostic) + if (HMSPrebuiltTheme.getColours() == null) { + HMSPrebuiltTheme.setTheme(HMSPrebuiltTheme.getDefaultHmsColorPalette()) + } viewModel.initSDK() setupNavGraph() diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/theme/ThemeExt.kt b/room-kit/src/main/java/live/hms/roomkit/ui/theme/ThemeExt.kt index fef12ac49..580b5ca6e 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/theme/ThemeExt.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/theme/ThemeExt.kt @@ -60,7 +60,7 @@ object HMSPrebuiltTheme { //temp fun getDefaultHmsColorPalette(): HMSRoomLayout.HMSRoomLayoutData.HMSRoomTheme.HMSColorPalette { val jsonStr = - "{\"alert_error_bright\":\"#FFB2B6\",\"alert_error_brighter\":\"#FFEDEC\",\"alert_error_default\":\"#C74E5B\",\"alert_error_dim\":\"#270005\",\"alert_success\":\"#36B37E\",\"alert_warning\":\"#FFAB00\",\"background_default\":\"#0B0E15\",\"background_dim\":\"#000000\",\"border_bright\":\"#272A31\",\"border_default\":\"#1D1F27\",\"on_primary_high\":\"#FFFFFF\",\"on_primary_low\":\"#84AAFF\",\"on_primary_medium\":\"#CCDAFF\",\"on_secondary_high\":\"#FFFFFF\",\"on_secondary_low\":\"#A4ABC0\",\"on_secondary_medium\":\"#D3D9F0\",\"on_surface_high\":\"#EFF0FA\",\"on_surface_low\":\"#8F9099\",\"on_surface_medium\":\"#404759\",\"primary_bright\":\"#538dff\",\"primary_default\":\"#2572ed\",\"primary_dim\":\"#004299\",\"primary_disabled\":\"#444954\",\"secondary_bright\":\"#70778B\",\"secondary_default\":\"#444954\",\"secondary_dim\":\"#293042\",\"secondary_disabled\":\"#404759\",\"surface_bright\":\"#272A31\",\"surface_brighter\":\"#2E3038\",\"surface_default\":\"#191B23\",\"surface_dim\":\"#11131A\"}" + "{\"alert_error_bright\":\"#FFB2B6\",\"alert_error_brighter\":\"#FFEDEC\",\"alert_error_default\":\"#C74E5B\",\"alert_error_dim\":\"#270005\",\"alert_success\":\"#36B37E\",\"alert_warning\":\"#FFAB00\",\"background_default\":\"#0B0E15\",\"background_dim\":\"#000000\",\"border_bright\":\"#272A31\",\"border_default\":\"#1D1F27\",\"on_primary_high\":\"#ffffff\",\"on_primary_low\":\"#7faaff\",\"on_primary_medium\":\"#cbdaff\",\"on_secondary_high\":\"#FFFFFF\",\"on_secondary_low\":\"#A4ABC0\",\"on_secondary_medium\":\"#D3D9F0\",\"on_surface_high\":\"#EFF0FA\",\"on_surface_low\":\"#8F9099\",\"on_surface_medium\":\"#C5C6D0\",\"primary_bright\":\"#3da6ff\",\"primary_default\":\"#2F80FF\",\"primary_dim\":\"#2059b2\",\"primary_disabled\":\"#338cff\",\"secondary_bright\":\"#70778B\",\"secondary_default\":\"#444954\",\"secondary_dim\":\"#293042\",\"secondary_disabled\":\"#404759\",\"surface_bright\":\"#272A31\",\"surface_brighter\":\"#2E3038\",\"surface_default\":\"#191B23\",\"surface_dim\":\"#11131A\"}" return gson.fromJson( jsonStr, HMSRoomLayout.HMSRoomLayoutData.HMSRoomTheme.HMSColorPalette::class.java From d4b482a18bdf128d9a84ccd9918a1d19030b36fb Mon Sep 17 00:00:00 2001 From: Gulzar Date: Wed, 19 Jun 2024 13:31:45 +0530 Subject: [PATCH 06/20] Update fragment_home.xml --- app/src/main/res/layout/fragment_home.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index a2b8531ee..a51c35b4f 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -43,7 +43,7 @@ android:orientation="vertical"> android:layout_gravity="center" android:layout_marginHorizontal="20dp" android:layout_marginTop="15dp" - android:layout_marginBottom="8dp" + android:gravity="center" android:text="@string/meeting_link_header_description" android:textColor="#E0ECFF" @@ -55,7 +55,6 @@ android:orientation="vertical"> android:layout_gravity="center" android:layout_marginHorizontal="20dp" android:layout_marginTop="15dp" - android:layout_marginBottom="8dp" android:maxLines="1" android:id="@+id/troubleshoot" android:drawableLeft="@drawable/ic_diagnostic_blue" From c60ba715321a3d36e37edc7514e6ec607a0ad29c Mon Sep 17 00:00:00 2001 From: Gulzar Date: Wed, 19 Jun 2024 13:32:28 +0530 Subject: [PATCH 07/20] Update fragment_home.xml --- app/src/main/res/layout/fragment_home.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index a51c35b4f..3a5adeb19 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -43,7 +43,6 @@ android:orientation="vertical"> android:layout_gravity="center" android:layout_marginHorizontal="20dp" android:layout_marginTop="15dp" - android:gravity="center" android:text="@string/meeting_link_header_description" android:textColor="#E0ECFF" @@ -68,7 +67,7 @@ android:orientation="vertical"> android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginHorizontal="24dp" - android:layout_marginTop="40dp" + android:layout_marginTop="24dp" android:autofillHints="" android:background="@drawable/gray_round_btn" android:fontFamily="@font/inter_regular" From 3fc5235b79b1a4381210baaf78de723ba9e1fa35 Mon Sep 17 00:00:00 2001 From: Gulzar Date: Wed, 19 Jun 2024 13:43:53 +0530 Subject: [PATCH 08/20] fix --- .../src/main/java/live/hms/roomkit/ViewExt.kt | 8 +++++++ .../PreCallConnectivityTestFragment.kt | 23 ++++++++++--------- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ViewExt.kt b/room-kit/src/main/java/live/hms/roomkit/ViewExt.kt index f925244cf..26b7a43d0 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ViewExt.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ViewExt.kt @@ -44,6 +44,14 @@ fun View.setOnSingleClickListener(l: (View) -> Unit) { setOnClickListener(OnSingleClickListener(l)) } +fun Number?.orZeroIfNullOrNaN(): Number { + return if (this == null || (this is Double && this.isNaN()) || (this is Float && this.isNaN())) { + 0 + } else { + this + } +} + fun View.gone() { if (this.visibility != View.GONE) this.visibility = View.GONE diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index 4f812ff53..33dc123f1 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -17,6 +17,7 @@ import com.xwray.groupie.GroupieAdapter import live.hms.roomkit.R import live.hms.roomkit.databinding.FragmentPreCallConnectivityTestBinding import live.hms.roomkit.gone +import live.hms.roomkit.orZeroIfNullOrNaN import live.hms.roomkit.setOnSingleClickListener import live.hms.roomkit.show import live.hms.roomkit.ui.diagnostic.DiagnosticViewModel @@ -192,28 +193,28 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Packets Lost", - "${videoStats?.packetsLost ?: 0}", + "${videoStats?.packetsLost.orZeroIfNullOrNaN()}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Packets Received", - "${videoStats?.packetsReceived ?: 0}", + "${videoStats?.packetsReceived.orZeroIfNullOrNaN()}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Sent", - "${round(videoStats?.bitrateSent ?: 0.0)}", + "${round(videoStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Received", - "${round(videoStats?.bitrateReceived ?: 0.0)}", + "${round(videoStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())}", R.drawable.ic_correct_tick_small ) ) @@ -221,7 +222,7 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Round-Trip Time (RTT)", - "${videoStats?.roundTripTime ?: 0}", + "${videoStats?.roundTripTime.orZeroIfNullOrNaN().toDouble()}", R.drawable.ic_correct_tick_small ) ) @@ -243,42 +244,42 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Bytes Received", - Utils.humanReadableByteCount(audioStats?.bytesReceived ?: 0, true, false), + Utils.humanReadableByteCount(audioStats?.bytesReceived.orZeroIfNullOrNaN().toLong(), true, false), R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Packets Lost", - "${audioStats?.packetsLost ?: 0}", + "${audioStats?.packetsLost.orZeroIfNullOrNaN()}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Packets Received", - "${audioStats?.packetsReceived ?: 0}", + "${audioStats?.packetsReceived.orZeroIfNullOrNaN()}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Sent", - "${round(audioStats?.bitrateSent ?: 0.0)}", + "${round(audioStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Received", - "${round(audioStats?.bitrateReceived ?: 0.0)}", + "${round(audioStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())}", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Round-Trip Time (RTT)", - "${audioStats?.roundTripTime ?: 0}", + "${audioStats?.roundTripTime.orZeroIfNullOrNaN()}", R.drawable.ic_correct_tick_small ) ) From 06e2d6e78082c614c8ff07fb93288b98f427b3e9 Mon Sep 17 00:00:00 2001 From: pratimmallick Date: Wed, 19 Jun 2024 15:59:10 +0530 Subject: [PATCH 09/20] Added units to bitrate --- .../fragments/PreCallConnectivityTestFragment.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index 33dc123f1..c6b4b2857 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -207,14 +207,14 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Bitrate Sent", - "${round(videoStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())}", + "${round(videoStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())} kbps", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Received", - "${round(videoStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())}", + "${round(videoStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())} kbps", R.drawable.ic_correct_tick_small ) ) @@ -265,14 +265,14 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Bitrate Sent", - "${round(audioStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())}", + "${round(audioStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())} kbps", R.drawable.ic_correct_tick_small ) ) add( DiagnosticDetail( "Bitrate Received", - "${round(audioStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())}", + "${round(audioStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())} kbps", R.drawable.ic_correct_tick_small ) ) From 92a26013919e0e1dad4e44902028d4636468001b Mon Sep 17 00:00:00 2001 From: pratimmallick Date: Wed, 19 Jun 2024 16:08:54 +0530 Subject: [PATCH 10/20] Converted rtt to MS --- .../PreCallConnectivityTestFragment.kt | 76 +++++++++---------- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index c6b4b2857..e28d0318b 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -222,7 +222,7 @@ class PreCallConnectivityTestFragment : Fragment() { add( DiagnosticDetail( "Round-Trip Time (RTT)", - "${videoStats?.roundTripTime.orZeroIfNullOrNaN().toDouble()}", + "${(videoStats?.roundTripTime.orZeroIfNullOrNaN().toDouble() * 1000).toInt()} ms", R.drawable.ic_correct_tick_small ) ) @@ -240,50 +240,48 @@ class PreCallConnectivityTestFragment : Fragment() { ) ).apply { if (isVideoAudioPublished) { - if (isVideoAudioPublished) { - add( - DiagnosticDetail( - "Bytes Received", - Utils.humanReadableByteCount(audioStats?.bytesReceived.orZeroIfNullOrNaN().toLong(), true, false), - R.drawable.ic_correct_tick_small - ) + add( + DiagnosticDetail( + "Bytes Received", + Utils.humanReadableByteCount(audioStats?.bytesReceived.orZeroIfNullOrNaN().toLong(), true, false), + R.drawable.ic_correct_tick_small ) - add( - DiagnosticDetail( - "Packets Lost", - "${audioStats?.packetsLost.orZeroIfNullOrNaN()}", - R.drawable.ic_correct_tick_small - ) + ) + add( + DiagnosticDetail( + "Packets Lost", + "${audioStats?.packetsLost.orZeroIfNullOrNaN()}", + R.drawable.ic_correct_tick_small ) - add( - DiagnosticDetail( - "Packets Received", - "${audioStats?.packetsReceived.orZeroIfNullOrNaN()}", - R.drawable.ic_correct_tick_small - ) + ) + add( + DiagnosticDetail( + "Packets Received", + "${audioStats?.packetsReceived.orZeroIfNullOrNaN()}", + R.drawable.ic_correct_tick_small ) - add( - DiagnosticDetail( - "Bitrate Sent", - "${round(audioStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())} kbps", - R.drawable.ic_correct_tick_small - ) + ) + add( + DiagnosticDetail( + "Bitrate Sent", + "${round(audioStats?.bitrateSent.orZeroIfNullOrNaN().toDouble())} kbps", + R.drawable.ic_correct_tick_small ) - add( - DiagnosticDetail( - "Bitrate Received", - "${round(audioStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())} kbps", - R.drawable.ic_correct_tick_small - ) + ) + add( + DiagnosticDetail( + "Bitrate Received", + "${round(audioStats?.bitrateReceived.orZeroIfNullOrNaN().toDouble())} kbps", + R.drawable.ic_correct_tick_small ) - add( - DiagnosticDetail( - "Round-Trip Time (RTT)", - "${audioStats?.roundTripTime.orZeroIfNullOrNaN()}", - R.drawable.ic_correct_tick_small - ) + ) + add( + DiagnosticDetail( + "Round-Trip Time (RTT)", + "${(audioStats?.roundTripTime.orZeroIfNullOrNaN().toDouble() * 1000).toInt()} ms", + R.drawable.ic_correct_tick_small ) - } + ) } } From 9263d01ecd055a5796d3493c468fa1f2c6819de8 Mon Sep 17 00:00:00 2001 From: Gulzar Date: Thu, 20 Jun 2024 12:12:10 +0530 Subject: [PATCH 11/20] Update PreCallMicFragment.kt --- .../roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt index 1bf1d0225..6e7c8ee83 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt @@ -27,6 +27,7 @@ import live.hms.roomkit.ui.meeting.MeetingFragment import live.hms.roomkit.ui.meeting.PreviewFragment import live.hms.roomkit.ui.theme.applyTheme import live.hms.roomkit.ui.theme.buttonEnabled +import live.hms.roomkit.ui.theme.saveButtonDisabled import live.hms.roomkit.ui.theme.saveButtonEnabled import live.hms.roomkit.ui.theme.setIconEnabled import live.hms.roomkit.util.setOnSingleClickListener @@ -114,15 +115,17 @@ class PreCallMicFragment : Fragment() { binding.progressBar.progress = it }) - + binding.btnPlayback.saveButtonDisabled() binding.btnRecord.setOnSingleClickListener { if (vm.isRecording) { vm.stopMicCheck() binding.btnRecord.text = "Record" + binding.btnPlayback.saveButtonEnabled() } else{ vm.startMicRecording() binding.btnRecord.text = "Stop recording" + binding.btnPlayback.saveButtonDisabled() } } From 20d3a2c5dbbfeb46f8a7f6308deca258c6ee4a69 Mon Sep 17 00:00:00 2001 From: Gulzar Date: Thu, 20 Jun 2024 16:38:55 +0530 Subject: [PATCH 12/20] Update PreCallMicFragment.kt --- .../hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt index 6e7c8ee83..e33c62371 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt @@ -115,8 +115,8 @@ class PreCallMicFragment : Fragment() { binding.progressBar.progress = it }) - binding.btnPlayback.saveButtonDisabled() + binding.btnPlayback.saveButtonDisabled() binding.btnRecord.setOnSingleClickListener { if (vm.isRecording) { vm.stopMicCheck() @@ -129,7 +129,7 @@ class PreCallMicFragment : Fragment() { } } - binding.btnPlayback.saveButtonEnabled() + binding.btnPlayback.setOnSingleClickListener { vm.startSpeakerTest() From 0db9936ff2cfed898d6eb5845878bea2d2d50be1 Mon Sep 17 00:00:00 2001 From: Gulzar Date: Thu, 20 Jun 2024 18:13:48 +0530 Subject: [PATCH 13/20] added changes --- .../fragments/PreCallCameraFragment.kt | 6 +++++- .../PreCallConnectivityTestFragment.kt | 2 +- .../res/layout/fragment_pre_call_camera.xml | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallCameraFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallCameraFragment.kt index b2a2fb19a..e22d8abb3 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallCameraFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallCameraFragment.kt @@ -16,7 +16,9 @@ import live.hms.roomkit.R import live.hms.roomkit.databinding.FragmentPreCallCameraBinding import live.hms.roomkit.databinding.FragmentPreCallMicBinding import live.hms.roomkit.databinding.FragmentPreCallRegionSelectionBinding +import live.hms.roomkit.gone import live.hms.roomkit.setOnSingleClickListener +import live.hms.roomkit.show import live.hms.roomkit.ui.diagnostic.DiagnosticViewModel import live.hms.roomkit.ui.diagnostic.DiagnosticViewModelFactory import live.hms.roomkit.ui.theme.applyTheme @@ -70,13 +72,15 @@ class PreCallCameraFragment : Fragment() { } }) + binding.buttonSwitchCamera.gone() vm.cameraTrackLiveData.observe(viewLifecycleOwner) { cameraTrack -> cameraTrack?.let { + binding.buttonSwitchCamera.show() binding.videoView.addTrack(it) } } - binding.videoView.setOnSingleClickListener { + binding.buttonSwitchCamera.setOnSingleClickListener { vm.cameraTrackLiveData.value?.switchCamera() } //check if camera permission is granted diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt index e28d0318b..5522a8729 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallConnectivityTestFragment.kt @@ -134,7 +134,7 @@ class PreCallConnectivityTestFragment : Fragment() { ) } val isVideoAudioPublished = - model.mediaServerReport.isSubcribeICEConnected && model.mediaServerReport.isPublishICEConnected && model.mediaServerReport.stats != null && model.mediaServerReport.stats?.video != null && model.mediaServerReport.stats?.audio != null + model.mediaServerReport.isSubcribeICEConnected && model.mediaServerReport.isPublishICEConnected && model.mediaServerReport.stats != null && model.mediaServerReport.stats?.video != null && model.mediaServerReport.stats?.audio != null && vm.isMediaPublished val mediaReport = ExpandableGroup( diff --git a/room-kit/src/main/res/layout/fragment_pre_call_camera.xml b/room-kit/src/main/res/layout/fragment_pre_call_camera.xml index c52df9768..57fc40e65 100644 --- a/room-kit/src/main/res/layout/fragment_pre_call_camera.xml +++ b/room-kit/src/main/res/layout/fragment_pre_call_camera.xml @@ -143,6 +143,25 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/bottom_header_text" /> + + + Date: Thu, 20 Jun 2024 18:17:41 +0530 Subject: [PATCH 14/20] Update fragment_pre_call_connectivity_test.xml --- .../src/main/res/layout/fragment_pre_call_connectivity_test.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/room-kit/src/main/res/layout/fragment_pre_call_connectivity_test.xml b/room-kit/src/main/res/layout/fragment_pre_call_connectivity_test.xml index d16527b6e..9859db205 100644 --- a/room-kit/src/main/res/layout/fragment_pre_call_connectivity_test.xml +++ b/room-kit/src/main/res/layout/fragment_pre_call_connectivity_test.xml @@ -182,7 +182,7 @@ android:nestedScrollingEnabled="false" android:layout_height="wrap_content" android:layout_marginTop="16dp" - android:paddingBottom="800dp" + android:paddingBottom="500dp" android:clipToPadding="false" android:layout_marginHorizontal="16dp" android:layout_marginBottom="16dp" From f837e68dcdf3fc6aba5ccb0ec3ed7d06aa6e15de Mon Sep 17 00:00:00 2001 From: Gulzar Date: Fri, 21 Jun 2024 15:26:32 +0530 Subject: [PATCH 15/20] added changes --- .../live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt | 4 ++++ .../hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt index 56d2005fd..fa7ad5be2 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt @@ -157,5 +157,9 @@ class DiagnosticViewModel(application: Application) : AndroidViewModel(applicati kotlin.runCatching { diagnosticSDK.startSpeakerCheck() } } + fun startHMSAudioManager() { + hmsSDK.startAudioManager() + } + } \ No newline at end of file diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt index e33c62371..d4b93ceb8 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt @@ -120,10 +120,12 @@ class PreCallMicFragment : Fragment() { binding.btnRecord.setOnSingleClickListener { if (vm.isRecording) { vm.stopMicCheck() + updateActionVolumeMenuIcon() binding.btnRecord.text = "Record" binding.btnPlayback.saveButtonEnabled() } else{ vm.startMicRecording() + updateActionVolumeMenuIcon() binding.btnRecord.text = "Stop recording" binding.btnPlayback.saveButtonDisabled() } @@ -159,7 +161,7 @@ class PreCallMicFragment : Fragment() { private fun updateActionVolumeMenuIcon( ) { - + vm.startHMSAudioManager() binding.btnSpeakerSelection.apply { when (vm.getAudioOutputRouteType()) { HMSAudioManager.AudioDevice.EARPIECE -> { From 9bf15168fa34ac0cac6ceda180919edf82761a2e Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Fri, 21 Jun 2024 17:48:29 +0530 Subject: [PATCH 16/20] Recreate sdk each time Signed-off-by: Aniket Kadam --- .../ui/diagnostic/DiagnosticProvider.kt | 36 +++++++++++++++++++ .../ui/diagnostic/DiagnosticViewModel.kt | 27 +++++--------- 2 files changed, 44 insertions(+), 19 deletions(-) create mode 100644 room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt new file mode 100644 index 000000000..3a611819c --- /dev/null +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt @@ -0,0 +1,36 @@ +package live.hms.roomkit.ui.diagnostic + +import android.app.Application +import android.content.Context +import androidx.core.content.edit +import live.hms.video.diagnostics.HMSDiagnostic +import live.hms.video.sdk.HMSSDK +import java.util.UUID + +class DiagnosticProvider(private val application: Application) { + private var hms : Pair? = null + private val consistentUserId = getConsistentUserIdOverSessions() + fun disposeOfDiagnostic() { hms = null } + fun getSdk() = hms?.first ?: createInstance(application).first + fun getDiagnosticSdk() : HMSDiagnostic = hms?.second ?: createInstance(application).second + private fun createInstance(application: Application) : Pair { + val hmsSDK = HMSSDK.Builder(application).build() + val diag = hmsSDK.getDiagnosticSDK(consistentUserId) + return Pair(hmsSDK, diag).apply { hms = this } + } + + private fun getConsistentUserIdOverSessions(): String { + val sharedPreferences = application.getSharedPreferences( + "your-activity-preference", Context.MODE_PRIVATE + ) + if (sharedPreferences.getString("saved_user_id_blocklist", null) == null) { + sharedPreferences.edit { + putString( + "saved_user_id_blocklist", UUID.randomUUID().toString() + ) + } + } + return sharedPreferences.getString("saved_user_id_blocklist", null).orEmpty() + } + +} \ No newline at end of file diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt index fa7ad5be2..9bb47e250 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt @@ -8,6 +8,7 @@ import androidx.lifecycle.MutableLiveData import live.hms.video.audio.HMSAudioManager import live.hms.video.diagnostics.HMSAudioDeviceCheckListener import live.hms.video.diagnostics.HMSCameraCheckListener +import live.hms.video.diagnostics.HMSDiagnostic import live.hms.video.diagnostics.models.ConnectivityCheckResult import live.hms.video.diagnostics.models.ConnectivityState import live.hms.video.error.HMSException @@ -20,10 +21,12 @@ import java.util.UUID class DiagnosticViewModel(application: Application) : AndroidViewModel(application) { // First create a new sdk instance - val hmsSDK by lazy { HMSSDK.Builder(application).build() } - var regionCode = "in" - val diagnosticSDK by lazy { hmsSDK.getDiagnosticSDK(getConsistentUserIdOverSessions()) } - + private var regionCode = "in" + private val diagnosticProvider = DiagnosticProvider(application) + private val diagnosticSDK : HMSDiagnostic + get() {return diagnosticProvider.getDiagnosticSdk()} + private val hmsSDK : HMSSDK + get() { return diagnosticProvider.getSdk()} val cameraTrackLiveData = MutableLiveData() fun cameraPermssionGranted() { diagnosticSDK.startCameraCheck( @@ -49,21 +52,6 @@ class DiagnosticViewModel(application: Application) : AndroidViewModel(applicati } } - - private fun getConsistentUserIdOverSessions(): String { - val sharedPreferences = getApplication().getSharedPreferences( - "your-activity-preference", Context.MODE_PRIVATE - ) - if (sharedPreferences.getString("saved_user_id_blocklist", null) == null) { - sharedPreferences.edit { - putString( - "saved_user_id_blocklist", UUID.randomUUID().toString() - ) - } - } - return sharedPreferences.getString("saved_user_id_blocklist", null).orEmpty() - } - fun stopCameraCheck() { diagnosticSDK.stopCameraCheck() cameraTrackLiveData.postValue(null) @@ -126,6 +114,7 @@ class DiagnosticViewModel(application: Application) : AndroidViewModel(applicati var isMediaCaptured : Boolean = false var isMediaPublished : Boolean = false fun startConnectivityTest() { + diagnosticProvider.disposeOfDiagnostic() isMediaPublished= false isMediaCaptured = false connectivityLiveData.postValue(null) From 10342517cff38dbea88b8288ee451eec83844c80 Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Fri, 21 Jun 2024 17:52:45 +0530 Subject: [PATCH 17/20] Fix option Signed-off-by: Aniket Kadam --- .../roomkit/ui/diagnostic/fragments/PreCallAudioSwitchDialog.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallAudioSwitchDialog.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallAudioSwitchDialog.kt index 80d6546ee..e83467268 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallAudioSwitchDialog.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallAudioSwitchDialog.kt @@ -182,7 +182,7 @@ class PreCallAudioSwitchDialog( private fun setAudioType(audioDevice: HMSAudioManager.AudioDevice) { vm.switchAudioOutput(audioDevice) - onOptionItemClicked?.invoke(vm.hmsSDK.getAudioOutputRouteType(), true) + onOptionItemClicked?.invoke(vm.getAudioOutputRouteType(), true) dismiss() } } \ No newline at end of file From ebeb8402b900c74212c4377a1eb328e692ffcd1e Mon Sep 17 00:00:00 2001 From: Aniket Kadam Date: Mon, 24 Jun 2024 11:38:34 +0530 Subject: [PATCH 18/20] Stop the check when disposing Signed-off-by: Aniket Kadam --- .../live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt index 3a611819c..8011e7e95 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticProvider.kt @@ -10,7 +10,10 @@ import java.util.UUID class DiagnosticProvider(private val application: Application) { private var hms : Pair? = null private val consistentUserId = getConsistentUserIdOverSessions() - fun disposeOfDiagnostic() { hms = null } + fun disposeOfDiagnostic() { + hms?.second?.stopConnectivityCheck() + hms = null + } fun getSdk() = hms?.first ?: createInstance(application).first fun getDiagnosticSdk() : HMSDiagnostic = hms?.second ?: createInstance(application).second private fun createInstance(application: Application) : Pair { From a24f7f3d20e7048cf0e2c455377c5f52f7e93f3a Mon Sep 17 00:00:00 2001 From: Gulzar Date: Mon, 24 Jun 2024 11:41:21 +0530 Subject: [PATCH 19/20] di --- .../live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt | 5 +---- .../roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt index fa7ad5be2..5cde3fdef 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/DiagnosticViewModel.kt @@ -157,9 +157,6 @@ class DiagnosticViewModel(application: Application) : AndroidViewModel(applicati kotlin.runCatching { diagnosticSDK.startSpeakerCheck() } } - fun startHMSAudioManager() { - hmsSDK.startAudioManager() - } - + } \ No newline at end of file diff --git a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt index d4b93ceb8..ab5036737 100644 --- a/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt +++ b/room-kit/src/main/java/live/hms/roomkit/ui/diagnostic/fragments/PreCallMicFragment.kt @@ -161,7 +161,6 @@ class PreCallMicFragment : Fragment() { private fun updateActionVolumeMenuIcon( ) { - vm.startHMSAudioManager() binding.btnSpeakerSelection.apply { when (vm.getAudioOutputRouteType()) { HMSAudioManager.AudioDevice.EARPIECE -> { From 48fd861d7dfbc3f4483506cb122cc25dde2db48e Mon Sep 17 00:00:00 2001 From: Gulzar Date: Wed, 26 Jun 2024 19:03:17 +0530 Subject: [PATCH 20/20] 2.9.62 release --- app/build.gradle | 2 +- gradle.properties | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 982ce302a..a7720fa40 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -62,7 +62,7 @@ dependencies { implementation "live.100ms:room-kit:$HMS_ROOM_KIT_VERSION" //100ms noise cancellation dep - def hmsVersion = "2.9.61" + def hmsVersion = "2.9.62" implementation "live.100ms:hms-noise-cancellation-android:$hmsVersion" // Navigation diff --git a/gradle.properties b/gradle.properties index f4fb4a824..97ac422bd 100644 --- a/gradle.properties +++ b/gradle.properties @@ -19,8 +19,8 @@ android.useAndroidX=true android.enableJetifier=true # Kotlin code style for this project: "official" or "obsolete": kotlin.code.style=official -100MS_APP_VERSION_CODE=375 -100MS_APP_VERSION_NAME=5.0.9 +100MS_APP_VERSION_CODE=376 +100MS_APP_VERSION_NAME=5.0.10 hmsRoomKitGroup=live.100ms -HMS_ROOM_KIT_VERSION=1.2.14 +HMS_ROOM_KIT_VERSION=1.2.15 android.suppressUnsupportedCompileSdk=33