Skip to content

Commit cc1ca14

Browse files
committed
Use closure vars for internal functions.
1 parent bbe590f commit cc1ca14

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

tests/tests.coffee

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,27 +100,28 @@ class VexTabTests
100100
# Remove some things that change but aren't relevant (IDs)
101101
getRenderedContent = (container, code, cssflex) ->
102102

103-
makeCanvas = (vex, test_id, flex)->
104-
c = $('<div></div>').css('flex', flex).css('font-size', '0.8em')
103+
idcounter += 1
104+
canvasid = 'rendered-' + idcounter
105+
106+
makeCanvas = ->
107+
c = $('<div></div>').css('flex', cssflex).css('font-size', '0.8em')
105108
p = $('<p></p>').css('margin-top', '0px')
106-
p.append($('<pre></pre>').text(vex).css('font-family', 'courier'))
109+
p.append($('<pre></pre>').text(code).css('font-family', 'courier'))
107110
c.append(p)
108-
canvas = $('<div></div>').addClass("vex-tabdiv").attr('id', test_id).css('flex', flex)
111+
canvas = $('<div></div>').addClass("vex-tabdiv").attr('id', canvasid)
109112
c.append(canvas)
110113
return c
111114

112-
renderCodeInCanvasId = (code, canvasid) ->
115+
renderCodeInCanvas = ->
113116
tab = new VexTab(new Artist(0, 0, 500, {scale: 0.8}))
114117
tab.parse(code)
115118
canvas = $('#' + canvasid)
116119
renderer = new Vex.Flow.Renderer(canvas[0], Vex.Flow.Renderer.Backends.SVG)
117120
renderer.getContext().setBackgroundFillStyle("#eed")
118121
tab.getArtist().render(renderer)
119122

120-
idcounter += 1
121-
canvasid = 'rendered-' + idcounter
122-
container.append(makeCanvas(code, canvasid, cssflex))
123-
renderCodeInCanvasId(code, canvasid)
123+
container.append(makeCanvas())
124+
renderCodeInCanvas()
124125
content = $('#' + canvasid).
125126
html().
126127
replace(/id=\".*?\"/g, 'id="xxx"')

0 commit comments

Comments
 (0)