Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard buggy transactions #1096

Closed
ignasirv opened this issue Sep 3, 2024 · 5 comments
Closed

Discard buggy transactions #1096

ignasirv opened this issue Sep 3, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ignasirv
Copy link

ignasirv commented Sep 3, 2024

Rationale

We have found a bug at the rom from this issue: #1073
The bug will be fixed for fork 10, 11 and so on, but we will need to reject from Erigon's side those transactions that trigger the bug at fork 9 😕
The transactions are those calls (not deploy) where the last opcode of the calldata is a PUSH or calls calling a contract where the last opcode of the bytecode is a PUSH

@ignasirv ignasirv added the enhancement New feature or request label Sep 3, 2024
@mandrigin
Copy link
Collaborator

Related to #1073

@hexoscott
Copy link
Collaborator

Opened this #1159 to help stop this from executing. A local test with the same code example from #1073 does return an "invalid code" response when attempting to call the contract.

@ignasirv
Copy link
Author

It's important to discard this transaction so it is not sent to executor

@Sharonbc01
Copy link

Hi @ignasirv this bug was to be fixed for fork 10, 11. Can this issue now be closed now?

@ignasirv
Copy link
Author

ignasirv commented Oct 8, 2024

Yes!

@ignasirv ignasirv closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants