Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic while analyzing paraspace-core #77

Open
GopherJ opened this issue Feb 8, 2023 · 3 comments
Open

Panic while analyzing paraspace-core #77

GopherJ opened this issue Feb 8, 2023 · 3 comments

Comments

@GopherJ
Copy link

GopherJ commented Feb 8, 2023

While analyzing https://github.com/para-space/paraspace-core, it paniced

@0xKitsune
Copy link
Owner

Thanks for opening up an issue. Ill take a look at this a little later today.

@dijkstra-dev
Copy link
Contributor

I was taking a look at this issue. It seems I was able to isolate where the problem is. Basically, where it breaks is in the file ParaProxyLib.sol#L345. But, apparently, the error is thrown by the solang-parser library and the problem is that the Paraspace library uses error as a variable name.

There were discussions about whether or not to add it as a keyword. If, for example, you change error to _error by hand, it doesn't break anymore (actually it does break again, but it's an Overflow bug in a latter check - maybe I'll post a fix later to discuss about this case).

Perhaps it can be modified so that instead of breaking and stopping all other checks, it shows which file(s) were left out of certain checks? or just show the error without breaking completely?

@dijkstra-dev
Copy link
Contributor

A discussion about it: ethereum/solidity#11743

In Code4rena, it has been classified as Non critical link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants